bito-code-review[bot] commented on code in PR #40512:
URL: https://github.com/apache/superset/pull/40512#discussion_r3324579599
##########
docs/docs/faq.mdx:
##########
@@ -181,6 +181,17 @@ value in milliseconds in the JSON Metadata field:
Here, the entire dashboard will refresh at once if periodic refresh is on. The
stagger time of 2.5
seconds is ignored.
+The manual **Refresh dashboard** button also staggers its chart requests. The
window is controlled
+by the `SUPERSET_DASHBOARD_MANUAL_REFRESH_STAGGER_MS` server config in
`superset_config.py`. The
+default is `5000` milliseconds, which matches the fallback used for timed
refresh. A per-dashboard
+`stagger_time` metadata value still wins when it is larger. Set the server
config to `0` to keep
+the older behavior where every chart request fires at the same time:
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete documentation of disable conditions</b></div>
<div id="fix">
The statement 'Set the server config to 0 to keep the older behavior' is
incomplete. The code at `dashboardState.ts:758` uses `Math.max(interval,
stagger_time || 5000)` — if a per-dashboard `stagger_time` is set (e.g., to
3000), staggering still applies even when the server config is 0. The old
(non-staggered) behavior requires both server config=0 AND no per-dashboard
stagger_time override.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- docs/docs/faq.mdx (lines 187-188)
- Set the server config to `0` to keep the older behavior where every chart
request fires
- at the same time:
+ Set the server config to `0` to keep the older behavior where every chart
request fires
+ at the same time. Note that this only takes effect when no per-dashboard
`stagger_time`
+ metadata is set; otherwise the larger of the two values applies.
```
</div>
</details>
</div>
<small><i>Code Review Run #6a63a7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
