semohr commented on code in PR #40481:
URL: https://github.com/apache/superset/pull/40481#discussion_r3324651390
##########
superset/views/base.py:
##########
@@ -413,25 +413,28 @@ def get_default_spinner_svg() -> str | None:
Returns:
str | None: SVG content as string, or None if file not found
"""
- try:
- # Path to frontend source SVG file (used by both frontend and backend)
- svg_path = os.path.join(
- os.path.dirname(__file__),
- "..",
- "..",
- "superset-frontend",
- "packages",
- "superset-ui-core",
- "src",
- "components",
- "assets",
- "images",
- "loading.svg",
- )
+ # Path to frontend source SVG file (used by both frontend and backend)
+ svg_path = os.path.join(
Review Comment:
I have run into this recently too. The path here is not available in the
docker image as the frontend src files are stripped. Instead of working around
the problem, why cant can change the path and make sure to bundle the assets
accordingly in the images?
I don't really have a say, but the fix here seems a bit hacky if you ask me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
