semohr commented on code in PR #40481:
URL: https://github.com/apache/superset/pull/40481#discussion_r3324651390
##########
superset/views/base.py:
##########
@@ -413,25 +413,28 @@ def get_default_spinner_svg() -> str | None:
Returns:
str | None: SVG content as string, or None if file not found
"""
- try:
- # Path to frontend source SVG file (used by both frontend and backend)
- svg_path = os.path.join(
- os.path.dirname(__file__),
- "..",
- "..",
- "superset-frontend",
- "packages",
- "superset-ui-core",
- "src",
- "components",
- "assets",
- "images",
- "loading.svg",
- )
+ # Path to frontend source SVG file (used by both frontend and backend)
+ svg_path = os.path.join(
Review Comment:
I’ve run into this recently as well. The issue seems to be that this path
isn’t available in the Docker image because the frontend `src` files are
stripped out.
Instead of working around it, could we change the path and make sure the
required assets are bundled correctly in the image? That feels a bit more
robust long-term.
I don’t have strong opinions on the implementation details, but the current
fix feels somewhat hacky to me and may not fully address the underlying issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
