durgaprasadml commented on code in PR #40481:
URL: https://github.com/apache/superset/pull/40481#discussion_r3324780000
##########
superset/views/base.py:
##########
@@ -413,25 +413,28 @@ def get_default_spinner_svg() -> str | None:
Returns:
str | None: SVG content as string, or None if file not found
"""
- try:
- # Path to frontend source SVG file (used by both frontend and backend)
- svg_path = os.path.join(
- os.path.dirname(__file__),
- "..",
- "..",
- "superset-frontend",
- "packages",
- "superset-ui-core",
- "src",
- "components",
- "assets",
- "images",
- "loading.svg",
- )
+ # Path to frontend source SVG file (used by both frontend and backend)
+ svg_path = os.path.join(
Review Comment:
Thanks for the review — that makes sense.
I agree that ensuring the asset is bundled correctly in the image would be a
cleaner long-term solution if the backend is expected to depend on this SVG at
runtime.
My reasoning for the current approach was:
- the UI already appears to fall back correctly in packaged/container
environments
- the missing frontend source asset currently behaves more like an optional
development-time dependency
- this issue seemed scoped primarily around suppressing unnecessary warning
noise without changing packaging behavior
I wanted to keep the fix minimal and avoid introducing changes to the
frontend build/package pipeline unless that was the preferred direction.
That said, I’m happy to adjust the implementation if bundling the asset into
the runtime image is the better long-term approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
