rusackas opened a new pull request, #40556:
URL: https://github.com/apache/superset/pull/40556

   ### SUMMARY
   
   Continues the GitHub Actions static-analysis (zizmor) hardening from #40545. 
For shell `run:` steps that referenced workflow / context / step values inline, 
those values are now passed through the step `env:` block and read as shell 
variables (and built-in variables like `$GITHUB_EVENT_NAME`, `$GITHUB_REF`, 
`$GITHUB_ACTOR` are used where available). This keeps externally-influenced 
values out of the command string itself.
   
   Covers the shell-step cases across `setup-backend`, `docker`, 
`ephemeral-env`, `ephemeral-env-pr-close`, `pre-commit`, `showtime-trigger`, 
`superset-translations`, and `latest-release-tag` — **21 findings**. No 
workflow logic, triggers, or behavior change.
   
   ### Scope note
   
   This is the shell-`run:` portion of the remaining zizmor backlog. The items 
that need per-case treatment are intentionally **left for a follow-up**:
   - `github-script` JS interpolation (mostly in `ephemeral-env`)
   - a couple of composite-action `run:` inputs (`superset-e2e`)
   - the `dangerous-trigger`, `cache-poisoning`, and one `github-env` items
   
   Splitting keeps this PR mechanical and easy to review, away from the 
deploy-critical JS/trigger changes.
   
   ### TESTING INSTRUCTIONS
   
   - [x] Re-ran the analyzer locally — the covered shell cases drop out (51 → 
30 remaining)
   - [x] YAML-parsed every modified file
   - [ ] `validate-all-ghas` passes on this PR
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue: n/a
   - [ ] Required feature flags: n/a
   - [ ] Changes UI: No
   - [ ] Includes DB Migration: No
   - [ ] Introduces new feature or API: No
   - [ ] Removes existing feature or API: No
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to