rusackas commented on code in PR #40556:
URL: https://github.com/apache/superset/pull/40556#discussion_r3329764902
##########
.github/workflows/tag-release.yml:
##########
@@ -68,6 +68,7 @@ jobs:
build: "true"
- name: Use Node.js 20
+ # zizmor: ignore[cache-poisoning] - node only runs the supersetbot
CLI; no dependency cache is enabled
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 20
Review Comment:
Good catch — applied `package-manager-cache: false` to both setup-node steps
in tag-release.yml (commit 2eed557851). The zizmor ignore comment now
accurately reflects that no cache is enabled.
##########
.github/workflows/tag-release.yml:
##########
@@ -125,6 +126,7 @@ jobs:
fetch-depth: 0
- name: Use Node.js 20
+ # zizmor: ignore[cache-poisoning] - node only runs the supersetbot
CLI; no dependency cache is enabled
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 20
Review Comment:
Fixed in commit 2eed557851 — `package-manager-cache: false` added to both
setup-node steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
