hainenber commented on code in PR #40556:
URL: https://github.com/apache/superset/pull/40556#discussion_r3329671199
##########
.github/workflows/tag-release.yml:
##########
@@ -125,6 +126,7 @@ jobs:
fetch-depth: 0
- name: Use Node.js 20
+ # zizmor: ignore[cache-poisoning] - node only runs the supersetbot
CLI; no dependency cache is enabled
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 20
Review Comment:
```suggestion
node-version: 20
package-manager-cache: false
```
##########
.github/workflows/tag-release.yml:
##########
@@ -68,6 +68,7 @@ jobs:
build: "true"
- name: Use Node.js 20
+ # zizmor: ignore[cache-poisoning] - node only runs the supersetbot
CLI; no dependency cache is enabled
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: 20
Review Comment:
Let's disable caching for workflows we've exempted from `zizmor` coverage
for `cache-poisoning` class . By default, [it's enabled by default in
v6+](https://github.com/actions/setup-node#breaking-changes-in-v6)
```suggestion
node-version: 20
package-manager-cache: false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
