kevin-lann commented on code in PR #35920:
URL: https://github.com/apache/superset/pull/35920#discussion_r3337856985


##########
superset/charts/schemas.py:
##########
@@ -459,7 +459,7 @@ class 
ChartDataAggregateOptionsSchema(ChartDataPostProcessingOperationOptionsSch
                 allow_none=False,
                 metadata={"description": "Columns by which to group by"},
             ),
-            metadata={"minLength": 1},
+            validate=Length(min=1),

Review Comment:
   Reverted this change back to what it was before. `metadata` is not for 
marshmallow validation, its for doc generation so no need to modify it. 
https://github.com/apache/superset/pull/35920/commits/f380adc5d1067924661151b0293f7f9dd667447c



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to