codeant-ai-for-open-source[bot] commented on code in PR #35920:
URL: https://github.com/apache/superset/pull/35920#discussion_r3337858284
##########
superset/charts/schemas.py:
##########
@@ -459,7 +459,7 @@ class
ChartDataAggregateOptionsSchema(ChartDataPostProcessingOperationOptionsSch
allow_none=False,
metadata={"description": "Columns by which to group by"},
),
- metadata={"minLength": 1},
+ validate=Length(min=1),
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not suggest adding marshmallow validation via `metadata`; in schema
files, `metadata` is for documentation generation, not validation.
**Applied to:**
- `**/schemas.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
