kevin-lann commented on code in PR #35920:
URL: https://github.com/apache/superset/pull/35920#discussion_r3337861184
##########
superset/themes/schemas.py:
##########
@@ -104,20 +110,20 @@ def validate_and_sanitize_json_data(self, value: str) ->
None:
# Note: This modifies the input data to ensure sanitized content is
stored
if sanitized_config != theme_config:
# Re-serialize the sanitized config
- self.context["sanitized_json_data"] = json.dumps(sanitized_config)
+ sanitized_json_context.set(json.dumps(sanitized_config))
Review Comment:
Fixed and added unit tests
https://github.com/apache/superset/pull/35920/commits/f380adc5d1067924661151b0293f7f9dd667447c
##########
superset/themes/schemas.py:
##########
@@ -131,7 +137,7 @@ def validate_and_sanitize_json_data(self, value: str) ->
None:
# Note: This modifies the input data to ensure sanitized content is
stored
if sanitized_config != theme_config:
# Re-serialize the sanitized config
- self.context["sanitized_json_data"] = json.dumps(sanitized_config)
+ sanitized_json_context.set(json.dumps(sanitized_config))
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
