rusackas commented on code in PR #40655:
URL: https://github.com/apache/superset/pull/40655#discussion_r3338267448
##########
superset/commands/temporary_cache/create.py:
##########
@@ -32,6 +32,7 @@ def __init__(self, cmd_params: CommandParameters):
@transaction(on_error=partial(on_error,
reraise=TemporaryCacheCreateFailedError))
def run(self) -> str:
+ self.validate()
Review Comment:
Valid observation. The Delete and Update sibling commands omit
self.validate() too. Aligning them is a reasonable cleanup but touches files
outside this PR's scope. Will file a follow-up to add validate() calls to the
sibling temporary_cache commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
