bito-code-review[bot] commented on code in PR #40655:
URL: https://github.com/apache/superset/pull/40655#discussion_r3338371958
##########
superset/commands/temporary_cache/create.py:
##########
@@ -32,6 +32,7 @@ def __init__(self, cmd_params: CommandParameters):
@transaction(on_error=partial(on_error,
reraise=TemporaryCacheCreateFailedError))
def run(self) -> str:
+ self.validate()
Review Comment:
<!-- Bito Reply -->
The Bito suggestion in this thread is valid and appropriate to apply. It
correctly identifies an inconsistency in the command pattern where
`self.validate()` is called in `CreateTemporaryCacheCommand` but omitted in its
sibling commands (`DeleteTemporaryCacheCommand` and
`UpdateTemporaryCacheCommand`). This creates a deviation from the expected
behavior pattern in the `temporary_cache` command family. Applying the
suggestion would align the sibling commands with the base contract and improve
predictability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
