bito-code-review[bot] commented on code in PR #40655:
URL: https://github.com/apache/superset/pull/40655#discussion_r3347398044
##########
superset/commands/temporary_cache/create.py:
##########
@@ -32,6 +32,7 @@ def __init__(self, cmd_params: CommandParameters):
@transaction(on_error=partial(on_error,
reraise=TemporaryCacheCreateFailedError))
def run(self) -> str:
+ self.validate()
Review Comment:
<!-- Bito Reply -->
The suggestion to align the `self.validate()` call across sibling commands
is appropriate. It improves consistency and predictability within the
`temporary_cache` command family, ensuring that all commands adhere to the
expected base contract.
**superset/commands/temporary_cache/create.py**
```
@transaction(on_error=partial(on_error,
reraise=TemporaryCacheCreateFailedError))
def run(self) -> str:
self.validate()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
