shelkesays commented on code in PR #40512:
URL: https://github.com/apache/superset/pull/40512#discussion_r3339560687
##########
docs/docs/faq.mdx:
##########
@@ -181,6 +181,17 @@ value in milliseconds in the JSON Metadata field:
Here, the entire dashboard will refresh at once if periodic refresh is on. The
stagger time of 2.5
seconds is ignored.
+The manual **Refresh dashboard** button also staggers its chart requests. The
window is controlled
+by the `SUPERSET_DASHBOARD_MANUAL_REFRESH_STAGGER_MS` server config in
`superset_config.py`. The
+default is `5000` milliseconds, which matches the fallback used for timed
refresh. A per-dashboard
+`stagger_time` metadata value still wins when it is larger. Set the server
config to `0` to keep
+the older behavior where every chart request fires at the same time:
Review Comment:
My previous comment cites `dashboardState.ts:748`, the `if (!interval) {
return Promise.all(...) }` early-return branch that fires when `interval=0`.
That branch returns before any dashboard metadata is read, so `stagger_time` is
not consulted on this path.
If you can point at the specific line of source where `stagger_time` is read
when `interval=0`, I will update the docs. Otherwise the current wording is
accurate and this thread should stay resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
