mikebridge commented on PR #40128:
URL: https://github.com/apache/superset/pull/40128#issuecomment-4614228509
Thanks @richardfogaca — all three addressed in 0142c106c4:
**1. Restore-via-import slug-restore flush ordering**
(\`importers/v1/utils.py:342\`): you're right, the prior flow flushed before
\`import_from_dict\` had a chance to apply the incoming slug, so a YAML upload
with a different slug couldn't unwedge a slug-conflicted restore. Fixed by
pre-applying \`config["slug"]\` to \`existing\` when present, so the
partial-index constraint sees the post-flush state with the new slug:
\`\`\`python
if is_soft_deleted:
existing.deleted_at = None
if "slug" in config:
existing.slug = config["slug"]
db.session.flush()
\`\`\`
Only the slug needs to be pre-applied because it's the only attribute the
partial-index constraint reads. The rest of the upload still flows through
\`import_from_dict\` downstream.
**2. \`_mysql_supports_functional_index\` 8.0 → 8.0.13**
(\`9e1f3b8c4d2a:87\`): correct, functional key parts shipped in MySQL 8.0.13
per the doc you linked. The prior \`>= (8, 0)\` gate would have admitted
8.0.0–8.0.12 into the partial-index branch and failed at index-creation time.
Tightened to \`>= (8, 0, 13)\` and expanded the docstring with the MySQL doc
reference.
**3. \`UPDATING.md:35\` embedded iframe wording**: rewrote the paragraph to
distinguish the dashboard API surface (returns 404 for soft-deleted parents)
from the embedded iframe URL (keeps rendering because the embed handler only
reads \`embedded.allowed_domains\` and \`embedded.dashboard_id\` without
dereferencing the parent dashboard). The 200 from \`/embedded/{uuid}\` the
regression test asserts now matches the documented behaviour.
Appreciate the line-anchored trace — your notes on the import path lining up
at \`utils.py:342\` with the flush at \`372\` made the fix obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
