bito-code-review[bot] commented on code in PR #40128: URL: https://github.com/apache/superset/pull/40128#discussion_r3358106272
########## superset/translations/tr/LC_MESSAGES/messages.po: ########## @@ -4144,6 +4144,9 @@ msgstr "Dashboard güncellenemedi." msgid "Dashboard could not be deleted." msgstr "Dashboard silinemedi." +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Turkish translation</b></div> <div id="fix"> The new `msgid "Dashboard could not be restored."` at line 4147 has an empty `msgstr ""` at line 4148. Turkish users will see the English text instead of a localized message. Compare with "Dashboard could not be deleted." → "Dashboard silinemedi." on line 4144-4145 which follows the same pattern with proper Turkish translation. The new entry should include its Turkish translation to maintain consistency and improve user experience for Turkish locale users. </div> </div> <small><i>Code Review Run #cb1ccb</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -4492,6 +4492,9 @@ msgstr "Das Dashboard konnte nicht aktualisiert werden." msgid "Dashboard could not be deleted." msgstr "Dashboard konnte nicht gelöscht werden." +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing German translation for restore</b></div> <div id="fix"> The `msgstr` is empty. For consistency with the German translation pattern used throughout this file (e.g., "Dashboard konnte nicht gelöscht werden." for "could not be deleted"), the missing translation should be: "Das Dashboard konnte nicht wiederhergestellt werden." </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/de/LC_MESSAGES/messages.po +++ b/superset/translations/de/LC_MESSAGES/messages.po @@ -4493,7 +4493,7 @@ msgstr "Dashboard konnte nicht gelöscht werden." msgid "Dashboard could not be restored." -msgstr "" +msgstr "Das Dashboard konnte nicht wiederhergestellt werden." msgid "Dashboard could not be updated." msgstr "Das Dashboard konnte nicht aktualisiert werden." ``` </div> </details> </div> <small><i>Code Review Run #cb1ccb</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ca/LC_MESSAGES/messages.po: ########## @@ -4425,6 +4425,9 @@ msgstr "La configuració de colors del dashboard no s'ha pogut actualitzar." msgid "Dashboard could not be deleted." msgstr "El dashboard no s'ha pogut eliminar." +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Catalan translation</b></div> <div id="fix"> The `msgstr` for "Dashboard could not be restored." is empty. Following the pattern of adjacent translation "Dashboard could not be deleted." (line 4425-4426) which translates to "El dashboard no s'ha pogut eliminar.", this should be "El dashboard no s'ha pogut restaurar." Users with Catalan locale will see untranslated English text otherwise. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/ca/LC_MESSAGES/messages.po +++ b/superset/translations/ca/LC_MESSAGES/messages.po @@ -4426,7 +4426,7 @@ msgstr "El dashboard no s'ha pogut eliminar." msgid "Dashboard could not be restored." -msgstr "" +msgstr "El dashboard no s'ha pogut restaurar." msgid "Dashboard could not be updated." msgstr "El dashboard no s'ha pogut actualitzar." ``` </div> </details> </div> <small><i>Code Review Run #cb1ccb</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -4555,6 +4555,9 @@ msgstr "Não foi possível atualizar o painel." msgid "Dashboard could not be deleted." msgstr "Não foi possível remover o painel." +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing pt_BR translation</b></div> <div id="fix"> The new `msgid "Dashboard could not be restored."` at line 4558 has an empty `msgstr ""`. Portuguese (Brazilian) users will see untranslated English text. Following the pattern of the adjacent message 'Dashboard could not be deleted.' (translated as "Não foi possível remover o painel."), use: "Não foi possível restaurar o painel." </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/pt_BR/LC_MESSAGES/messages.po +++ superset/translations/pt_BR/LC_MESSAGES/messages.po @@ -4556,7 +4556,7 @@ msgstr "Não foi possível remover o painel." msgid "Dashboard could not be restored." -msgstr "" +msgstr "Não foi possível restaurar o painel." msgid "Dashboard could not be updated." msgstr "Não foi possível atualizar o painel." ``` </div> </details> </div> <small><i>Code Review Run #cb1ccb</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -4376,6 +4376,9 @@ msgstr "看板無法更新。" msgid "Dashboard could not be deleted." msgstr "看板無法被删除。" +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing zh_TW translation</b></div> <div id="fix"> The new msgid "Dashboard could not be restored." has an empty msgstr (""). Similar error messages "Dashboard could not be deleted." and "Dashboard could not be updated." in the same file have proper Chinese (Traditional) translations. This creates inconsistent UX where zh_TW users see English text for the restore error while other dashboard errors appear in Chinese. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/zh_TW/LC_MESSAGES/messages.po +++ b/superset/translations/zh_TW/LC_MESSAGES/messages.po @@ -4377,7 +4377,7 @@ msgstr "看板無法被删除。" msgid "Dashboard could not be restored." -msgstr "" +msgstr "看板無法恢復。" msgid "Dashboard could not be updated." msgstr "看板無法更新。" ``` </div> </details> </div> <small><i>Code Review Run #cb1ccb</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -4331,6 +4331,9 @@ msgstr "La tua query non può essere salvata" msgid "Dashboard could not be deleted." msgstr "La tua query non può essere salvata" +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty Italian translation</b></div> <div id="fix"> The translation for "Dashboard could not be restored." is left empty (`msgstr ""`), causing Italian users to see the untranslated English error message. This error originates from `DashboardRestoreFailedError` at `superset/commands/dashboard/exceptions.py:81` and surfaces when a dashboard restore operation fails. </div> </div> <small><i>Code Review Run #cb1ccb</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -4585,6 +4585,9 @@ msgstr "No se ha podido actualizar la configuración de color del panel de contr msgid "Dashboard could not be deleted." msgstr "No se ha podido eliminar el panel de control." +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Spanish translation</b></div> <div id="fix"> The Spanish translation for 'Dashboard could not be restored.' is empty. Spanish users will see untranslated English text when a dashboard restore operation fails. Add the translation following the established pattern: 'No se ha podido [action] el panel de control.' for consistency with 'deleted' (eliminar) and 'updated' (actualizar). </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/es/LC_MESSAGES/messages.po (lines 4585-4593)--- 4585: msgid "Dashboard could not be deleted." 4586: msgstr "No se ha podido eliminar el panel de control." 4587: 4588: +msgid "Dashboard could not be restored." 4589: -msgstr "" 4589: +msgstr "No se ha podido restaurar el panel de control." 4590: 4591: msgid "Dashboard could not be updated." 4592: msgstr "No se ha podido actualizar el panel de control." 4593: ``` </div> </details> </div> <small><i>Code Review Run #cb1ccb</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
