bito-code-review[bot] commented on code in PR #40128: URL: https://github.com/apache/superset/pull/40128#discussion_r3365384858
########## superset/translations/ar/LC_MESSAGES/messages.po: ########## @@ -4441,6 +4441,9 @@ msgstr "تعذر تحديث لوحة المعلومات." msgid "Dashboard could not be deleted." msgstr "تعذر حذف لوحة المعلومات." +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Arabic translation</b></div> <div id="fix"> The new `msgid "Dashboard could not be restored."` entry has an empty `msgstr ""`. Users with Arabic locale will see the untranslated English string. Based on the pattern of similar messages in this file (e.g., "Dashboard could not be deleted." → "تعذر حذف لوحة المعلومات."), the expected translation is "تعذر استعادة لوحة المعلومات.". </div> </div> <small><i>Code Review Run #617998</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/uk/LC_MESSAGES/messages.po: ########## @@ -4330,6 +4330,9 @@ msgstr "Не вдалося оновити налаштування кольор msgid "Dashboard could not be deleted." msgstr "Не вдалося вилучити звіт." +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Ukrainian translation</b></div> <div id="fix"> The Ukrainian translation is empty. Users with Ukrainian locale will see the untranslated English message "Dashboard could not be restored." instead of a proper Ukrainian translation. Following the established pattern in this file, the translation should be "Не вдалося відновити звіт.". </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/uk/LC_MESSAGES/messages.po +++ superset/translations/uk/LC_MESSAGES/messages.po @@ -4331,7 +4331,7 @@ msgstr "Не вдалося вилучити звіт." msgid "Dashboard could not be restored." -msgstr "" +msgstr "Не вдалося відновити звіт." msgid "Dashboard could not be updated." msgstr "Не вдалось оновити звіт." ``` </div> </details> </div> <small><i>Code Review Run #617998</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/cs/LC_MESSAGES/messages.po: ########## @@ -4416,6 +4416,9 @@ msgstr "Konfiguraci barev nástěnky se nepodařilo aktualizovat." msgid "Dashboard could not be deleted." msgstr "Nástěnku se nepodařilo smazat." +msgid "Dashboard could not be restored." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Czech translation</b></div> <div id="fix"> The `msgstr` is empty, so Czech users will see the untranslated English message "Dashboard could not be restored." when a dashboard restore fails. Provide the Czech translation to match the pattern of adjacent entries. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/cs/LC_MESSAGES/messages.po +++ superset/translations/cs/LC_MESSAGES/messages.po @@ -4417,7 +4417,7 @@ msgstr "Nástěnku se nepodařilo smazat." msgid "Dashboard could not be restored." -msgstr "" +msgstr "Nástěnku se nepodařilo obnovit." msgid "Dashboard could not be updated." msgstr "Nástěnku se nepodařilo aktualizovat." ``` </div> </details> </div> <small><i>Code Review Run #617998</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
