richardfogaca commented on PR #40473: URL: https://github.com/apache/superset/pull/40473#issuecomment-4632486634
I pushed a couple of follow-up commits to address the remaining review feedback so we can wrap this PR up. What changed: - `get_chart_info`: aligned the unsaved `form_data_key` path with the saved-chart path by applying `select_columns` during serialization, while still returning `ChartError` objects unchanged. - `get_dataset_info`: made `column_fields=[]` behave as an explicit empty field selection instead of falling through to the full verbose column payload. It now returns the required `column_name` minimum. - `get_dashboard_info`: kept `filter_state` out of the lean default projection and relies on the permalink-specific path to include it only when a permalink request uses the default selection. I also added focused regression coverage for these paths and re-ran the relevant MCP tests plus Ruff on the touched files. The existing PR review threads are resolved from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
