aminghadersohi commented on PR #40473: URL: https://github.com/apache/superset/pull/40473#issuecomment-4624684311
Addressed the open review feedback: **`richardfogaca`'s comment (get_dashboard_info filter_state):** When `permalink_key` is supplied and the caller has not explicitly overridden `select_columns`, the tool now explicitly ensures `filter_state` is in the effective columns before calling `model_dump`. This makes the intent clear and future-proofs against the default list changing — `filter_state` is always guaranteed to be present when a permalink was provided. Added `test_get_dashboard_info_permalink_key_includes_filter_state` to verify the behavior. **Bito suggestion (GetDatasetInfoRequest.column_fields validators):** Added `TestGetDatasetInfoRequestValidators` in `test_dataset_tools.py` with four cases: JSON string input, explicit empty list, `None` (falls back to default), and field omitted (falls back to default). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
