Copilot commented on code in PR #40860: URL: https://github.com/apache/superset/pull/40860#discussion_r3375254240
########## tests/unit_tests/commands/databases/upload_command_test.py: ########## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import io +from unittest.mock import MagicMock + +import pytest +from pytest_mock import MockerFixture +from werkzeug.datastructures import FileStorage + +from superset.commands.database.exceptions import DatabaseUploadFileTooLarge +from superset.commands.database.uploaders.base import UploadCommand + + +def _file(contents: bytes) -> FileStorage: + return FileStorage(stream=io.BytesIO(contents), filename="data.bin") + + +def test_file_size_bytes_does_not_consume_stream() -> None: + file = _file(b"abcdefghij") # 10 bytes + assert UploadCommand._file_size_bytes(file) == 10 + # the stream is left at its original position so processing still works + assert file.stream.read() == b"abcdefghij" + + +def _command(file: FileStorage) -> UploadCommand: + # the reader is not exercised by validate(); a stub is sufficient + return UploadCommand( + model_id=1, + table_name="t", + file=file, + schema=None, + reader=MagicMock(), + ) + + +def _stub_passing_checks(mocker: MockerFixture) -> None: + model = mocker.MagicMock() + model.db_engine_spec.supports_file_upload = True + mocker.patch( + "superset.commands.database.uploaders.base.DatabaseDAO.find_by_id", + return_value=model, + ) + mocker.patch( + "superset.commands.database.uploaders.base.schema_allows_file_upload", + return_value=True, + ) + + +def test_validate_rejects_file_over_limit( + app_context: None, mocker: MockerFixture +) -> None: + _stub_passing_checks(mocker) + mocker.patch.dict( + "superset.commands.database.uploaders.base.current_app.config", + {"UPLOAD_MAX_FILE_SIZE_BYTES": 4}, + ) + command = _command(_file(b"too many bytes")) + with pytest.raises(DatabaseUploadFileTooLarge): + command.validate() + + +def test_validate_allows_file_within_limit( + app_context: None, mocker: MockerFixture +) -> None: + _stub_passing_checks(mocker) + mocker.patch.dict( + "superset.commands.database.uploaders.base.current_app.config", + {"UPLOAD_MAX_FILE_SIZE_BYTES": 1024}, + ) + command = _command(_file(b"small")) + command.validate() # should not raise + + +def test_validate_no_limit_when_unset(app_context: None, mocker: MockerFixture) -> None: Review Comment: The test name says "when_unset", but the config key is explicitly set to None (which is the documented way to disable the limit). Renaming the test will better reflect the behavior being exercised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
