bito-code-review[bot] commented on code in PR #40860:
URL: https://github.com/apache/superset/pull/40860#discussion_r3376486505
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -4553,6 +4553,9 @@ msgstr "Настройки базы данных обновлены"
msgid "Database type does not support file uploads."
msgstr "База данных не поддерживает загрузку файлов"
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to fill in the translation string is based on a
general rule for user-facing text. However, your assessment is correct: for
Superset's i18n workflow, leaving new strings with an empty `msgstr ""` is the
standard practice, as translations are managed externally via Crowdin. You do
not need to apply this suggestion.
##########
superset/translations/pl/LC_MESSAGES/messages.po:
##########
@@ -4797,6 +4797,9 @@ msgstr "Ustawienia bazy danych zaktualizowane"
msgid "Database type does not support file uploads."
msgstr "Typ bazy danych nie obsługuje przesyłania plików."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The suggestion to fill in the translation string is not appropriate in this
context. In Superset's i18n workflow, new user-facing strings are intentionally
added with empty `msgstr ""` values. These are subsequently populated by the
translator community via Crowdin, and committing machine-generated translations
directly in the source PR would bypass this established review process.
**superset/translations/pl/LC_MESSAGES/messages.po**
```
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
```
##########
superset/translations/ca/LC_MESSAGES/messages.po:
##########
@@ -4655,6 +4655,9 @@ msgstr "Configuració de base de dades actualitzada"
msgid "Database type does not support file uploads."
msgstr "El tipus de base de dades no suporta pujades de fitxers."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to provide a translation is based on a general
rule for user-facing text. However, your assessment is correct: in the context
of Superset's i18n workflow, new strings are intentionally committed with empty
`msgstr` values to be populated later by the translation community via Crowdin.
You should not apply this suggestion, as it would bypass the established
translation process.
**superset/translations/ca/LC_MESSAGES/messages.po**
```
4658: msgid "Database upload file exceeds the maximum allowed size."
4659:-msgstr ""
4659:+msgstr "La mida del fitxer de pujada de base de dades supera el màxim
permès."
```
##########
superset/translations/ko/LC_MESSAGES/messages.po:
##########
@@ -4542,6 +4542,9 @@ msgstr "데이터베이스를 업데이트할 수 없습니다."
msgid "Database type does not support file uploads."
msgstr ""
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to add a Korean translation for the new error
message is not required in this context. As you noted, Superset's i18n workflow
relies on the Crowdin platform for translation management, and committing empty
`msgstr` entries for new strings is the standard practice to ensure they are
correctly picked up by the translation pipeline.
##########
superset/translations/uk/LC_MESSAGES/messages.po:
##########
@@ -4543,6 +4543,9 @@ msgstr "Параметри бази даних оновлено"
msgid "Database type does not support file uploads."
msgstr "База даних не підтримує підвантаження файлів."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
+
Review Comment:
<!-- Bito Reply -->
The suggestion to fill in the `msgstr` for the new string is not required in
this context. As you noted, Superset's i18n workflow relies on external
translation management via Crowdin, and committing empty `msgstr` entries for
new strings is the standard practice to ensure the translation process is not
bypassed.
##########
superset/translations/fi/LC_MESSAGES/messages.po:
##########
@@ -8152,6 +8152,9 @@ msgstr "Tietokannan asetukset päivitetty"
msgid "Database type does not support file uploads."
msgstr "Tietokantityyppi ei tue tiedostojen lataamista."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The suggestion to provide a translation for the new string is standard for
many projects, but as you noted, Superset's i18n workflow relies on Crowdin for
community-driven translations. Committing empty `msgstr` entries is the correct
practice here to ensure the string is picked up by the translation platform
without bypassing that process. You can safely ignore this suggestion, and if
you find these types of automated localization reminders unhelpful for your
specific workflow, you can opt to avoid them via the link provided in the
review comment.
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -4723,6 +4723,9 @@ msgstr "Datenbankeinstellungen aktualisiert"
msgid "Database type does not support file uploads."
msgstr "Der Datenbanktyp unterstützt keine Datei-Uploads."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to provide a German translation for the new string
is not required in this context. As you noted, Superset's i18n workflow relies
on Crowdin for translations, and committing empty `msgstr ""` entries for new
strings is the standard, intended practice to ensure they are picked up by the
translation platform.
##########
superset/translations/mi/LC_MESSAGES/messages.po:
##########
@@ -4584,6 +4584,9 @@ msgstr "Kua whakahouhia ngā tautuhinga pātengi raraunga"
msgid "Database type does not support file uploads."
msgstr "Karekau e tautoko te momo pātengi raraunga i ngā tukuake kōnae."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to provide a translation is based on a general
rule for incomplete entries, but in the context of Superset's i18n workflow,
this is indeed the expected and correct state for new strings. The translation
process is handled externally via Crowdin, and committing an empty `msgstr` is
the standard practice to ensure the string is correctly picked up for
translation without bypassing that workflow. You may disregard this suggestion
as it is a false positive in this specific context.
**superset/translations/mi/LC_MESSAGES/messages.po**
```
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
```
##########
superset/translations/es/LC_MESSAGES/messages.po:
##########
@@ -4818,6 +4818,9 @@ msgstr "Configuración de la base de datos actualizada"
msgid "Database type does not support file uploads."
msgstr "El tipo de base de datos no admite subidas de archivos."
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to fill the `msgstr` field is not required in this
case. As you noted, leaving the `msgstr` empty is the standard workflow for new
strings in Superset, as translations are managed externally via Crowdin. You
can safely ignore this suggestion.
**superset/translations/es/LC_MESSAGES/messages.po**
```
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
```
##########
superset/translations/pt/LC_MESSAGES/messages.po:
##########
@@ -4628,6 +4628,9 @@ msgstr "Não foi possível gravar a sua query"
msgid "Database type does not support file uploads."
msgstr "Origem de dados %(name)s já existe"
+msgid "Database upload file exceeds the maximum allowed size."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to provide a translation for the new string is a
standard check for completeness. However, as you noted, for Superset's i18n
workflow, new strings are intentionally left with empty `msgstr` entries to be
populated later via the translation platform. You can safely ignore this
suggestion as it is a false positive in the context of your project's
translation process.
**superset/translations/pt/LC_MESSAGES/messages.po**
```
msgid "Database upload file exceeds the maximum allowed size."
-msgstr ""
+msgstr "O ficheiro carregado excede o tamanho máximo permitido."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
