bito-code-review[bot] commented on code in PR #40860: URL: https://github.com/apache/superset/pull/40860#discussion_r3377154741
########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -4563,6 +4563,9 @@ msgstr "La tua query non può essere salvata" msgid "Database type does not support file uploads." msgstr "Sorgente dati e tipo di grafico" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Italian translation</b></div> <div id="fix"> The new translation entry for 'Database upload file exceeds the maximum allowed size.' has an empty `msgstr`. Italian users will see the untranslated English message. Add the Italian translation. </div> </div> <small><i>Code Review Run #80e484</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -4604,6 +4604,9 @@ msgstr "数据库设置已更新" msgid "Database type does not support file uploads." msgstr "数据库不支持子查询" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Chinese translation</b></div> <div id="fix"> The new translation key `Database upload file exceeds the maximum allowed size.` has an empty `msgstr` value. This key is used in `superset/commands/database/exceptions.py:123` for the `DatabaseUploadFileTooLarge` exception. Users will see the untranslated English message instead of localized text. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/zh/LC_MESSAGES/messages.po (lines 4607-4608) --- 4607: msgid "Database upload file exceeds the maximum allowed size." 4608: -msgstr "" 4608: +msgstr "数据库上传文件超出最大允许大小" 4609: + ``` </div> </details> </div> <small><i>Code Review Run #80e484</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -17928,10 +17931,6 @@ msgstr "Importa" msgid "value descending" msgstr "Importa" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect Italian translation</b></div> <div id="fix"> The translation 'Importa' (meaning 'Import') for 'value descending' is incorrect. Italian users will see 'Import' instead of 'value descending'. This string is used in the pivot table chart plugin (plugin-chart-pivot-table/src/plugin/controlPanel.tsx:321,349). </div> </div> <small><i>Code Review Run #80e484</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/nl/LC_MESSAGES/messages.po: ########## @@ -4688,6 +4688,9 @@ msgstr "Database instellingen bijgewerkt" msgid "Database type does not support file uploads." msgstr "Database ondersteunt geen subquery’s" +msgid "Database upload file exceeds the maximum allowed size." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Dutch translation</b></div> <div id="fix"> The new translation entry for 'Database upload file exceeds the maximum allowed size.' has an empty `msgstr`. Dutch users will see the English text instead of a localized error message. Per rule 6516, all user-facing strings should be properly translated. </div> </div> <small><i>Code Review Run #80e484</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
