bito-code-review[bot] commented on code in PR #40885:
URL: https://github.com/apache/superset/pull/40885#discussion_r3379998213
##########
superset/translations/th/LC_MESSAGES/messages.po:
##########
@@ -1456,6 +1462,11 @@ msgstr "เกิดการหมดเวลาขณะสร้างไฟ
msgid "A timeout occurred while generating a dataframe."
msgstr "เกิดการหมดเวลาขณะสร้าง dataframe"
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh, zh_TW]
+msgid "A timeout occurred while generating an xlsx."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Empty translation after fuzzy removal</b></div>
<div id="fix">
Removing the `fuzzy` flag from "A timeout occurred while generating an
xlsx." leaves `msgstr` empty (line 1468). Per the documented workflow in
`howtos.md` (lines 401-410), the `fuzzy` flag signals that a machine-generated
translation needs human review before use. Removing it with an empty msgstr
causes the English string to display to Thai users instead of a translated
message.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/th/LC_MESSAGES/messages.po (lines 1465-1469) ---
1465: # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs:
ar, ca, cs,
1466: # de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh,
zh_TW]
1467: -#, fuzzy
1467: +#, fuzzy
1468: msgid "A timeout occurred while generating an xlsx."
1469: -msgstr ""
1469: +msgstr "เกิดการหมดเวลาขณะสร้างไฟล์ xlsx"
```
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/870adf4/docs/developer_docs/contributing/howtos.md";>howtos.md:403-408</a>
</li>
</ul>
</details>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/th/LC_MESSAGES/messages.po:
##########
@@ -21486,6 +21517,11 @@ msgstr ""
msgid "Send as CSV"
msgstr "ส่งเป็น CSV"
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh, zh_TW]
+msgid "Send as Excel"
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Empty translation after fuzzy removal</b></div>
<div id="fix">
Removing the `fuzzy` flag from "Send as Excel" leaves `msgstr` empty (line
21524). Per the documented workflow in `howtos.md` (lines 401-410), the `fuzzy`
flag signals that a machine-generated translation needs human review before
use. Removing it with an empty msgstr causes the English string to display to
Thai users instead of a translated message.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/th/LC_MESSAGES/messages.po (lines 21520-21527) ---
21520: # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs:
ar, ca, cs,
21521: # de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh,
zh_TW]
21522: msgid "Send as Excel"
21523: +#, fuzzy
21524: msgstr ""
21525: # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs:
ca, cs, de,
21526: # es, fa, fr, ja, lv, mi, ru, sk, sl, uk]
21527: -msgstr "ส่งเป็นข้อความ"
```
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/870adf4/docs/developer_docs/contributing/howtos.md";>howtos.md:403-408</a>
</li>
</ul>
</details>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/lv/LC_MESSAGES/messages.po:
##########
@@ -6219,6 +6226,9 @@ msgstr "Piemērs"
msgid "Examples"
msgstr "Piemēri"
+msgid "Excel (XLSX) attached in email"
+msgstr ""
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Empty translation for UI label</b></div>
<div id="fix">
The msgstr is now empty, causing English text to display in the UI. This is
used in ReportModal/index.tsx:286 and AlertReportModal.tsx. Suggest: 'Excel
(XLSX) pielikums e-pastā'
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/lv/LC_MESSAGES/messages.po:
##########
@@ -965,6 +969,9 @@ msgstr "Ģenerējot CSV, iestājās noildze."
msgid "A timeout occurred while generating a dataframe."
msgstr "Ģenerējot datu rāmi, iestājās noildze."
+msgid "A timeout occurred while generating an xlsx."
+msgstr ""
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Empty translation for user message</b></div>
<div id="fix">
The msgstr is now empty, causing English text to display to Latvian users.
This is an actively used error message in
superset/commands/report/exceptions.py:284. Suggest: 'Ģenerējot xlsx, iestājās
noildze.'
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/lv/LC_MESSAGES/messages.po:
##########
@@ -11948,6 +11971,9 @@ msgstr ""
msgid "Send as CSV"
msgstr "Sūtīt kā CSV"
+msgid "Send as Excel"
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Empty translation for menu item</b></div>
<div id="fix">
The msgstr is now empty, causing English text to display in the dropdown
menu. This is used in AlertReportModal.tsx:225. Suggest: 'Sūtīt kā Excel'
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/th/LC_MESSAGES/messages.po:
##########
@@ -10926,6 +10937,11 @@ msgstr "ตัวอย่าง"
msgid "Examples"
msgstr "ตัวอย่าง"
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh, zh_TW]
+msgid "Excel (XLSX) attached in email"
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Empty translation after fuzzy removal</b></div>
<div id="fix">
Removing the `fuzzy` flag from "Excel (XLSX) attached in email" leaves
`msgstr` empty (line 10944). Per the documented workflow in `howtos.md` (lines
401-410), the `fuzzy` flag signals that a machine-generated translation needs
human review before use. Removing it with an empty msgstr causes the English
string to display to Thai users instead of a translated message.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/th/LC_MESSAGES/messages.po (lines 10940-10946) ---
10940: # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs:
ar, ca, cs,
10941: # de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh,
zh_TW]
10942: msgid "Excel (XLSX) attached in email"
10943: -#, fuzzy
10943: +#, fuzzy
10944: msgstr ""
10945: -msgstr "แนบ CSV ที่จัดรูปแบบแล้วในอีเมล"
10946: # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs:
fr, ja, lv,
10947: # ru, uk]
```
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/870adf4/docs/developer_docs/contributing/howtos.md";>howtos.md:403-408</a>
</li>
</ul>
</details>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/th/LC_MESSAGES/messages.po:
##########
@@ -19153,6 +19175,11 @@ msgstr "การดำเนินการกำหนดการรายง
msgid "Report Schedule execution failed when generating a screenshot."
msgstr "การดำเนินการกำหนดการรายงานล้มเหลวขณะสร้างภาพหน้าจอ"
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
+# de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh, zh_TW]
+msgid "Report Schedule execution failed when generating an xlsx."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Empty translation after fuzzy removal</b></div>
<div id="fix">
Removing the `fuzzy` flag from "Report Schedule execution failed when
generating an xlsx." leaves `msgstr` empty (line 19182). Per the documented
workflow in `howtos.md` (lines 401-410), the `fuzzy` flag signals that a
machine-generated translation needs human review before use. Removing it with
an empty msgstr causes the English string to display to Thai users instead of a
translated message.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/th/LC_MESSAGES/messages.po (lines 19178-19184) ---
19178: # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs:
ar, ca, cs,
19179: # de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh,
zh_TW]
19180: msgid "Report Schedule execution failed when generating an xlsx."
19181: +#, fuzzy
19182: msgstr ""
19183: # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs:
ar, ca, cs,
19184: -msgstr "การดำเนินการกำหนดการรายงานล้มเหลวขณะสร้างไฟล์ CSV"
19184: +#, fuzzy
19185: # de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk, zh,
zh_TW]
```
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/870adf4/docs/developer_docs/contributing/howtos.md";>howtos.md:403-408</a>
</li>
</ul>
</details>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -5837,6 +5844,9 @@ msgstr "例"
msgid "Examples"
msgstr "サンプル"
+msgid "Excel (XLSX) attached in email"
+msgstr ""
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Japanese translation</b></div>
<div id="fix">
Empty `msgstr` at line 5848 causes English fallback. This label is used in
`AlertReportModal.tsx` and `ReportModal.tsx` as a user-selectable option, so
Japanese users will see the English label in dropdowns.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -882,6 +886,9 @@ msgstr "CSVの生成中にタイムアウトが発生しました。"
msgid "A timeout occurred while generating a dataframe."
msgstr "データフレームの生成中にタイムアウトが発生しました。"
+msgid "A timeout occurred while generating an xlsx."
+msgstr ""
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Japanese translation</b></div>
<div id="fix">
Empty `msgstr` at line 890 causes English fallback in Japanese UI. This
message is used in `superset/commands/report/exceptions.py` and will display
the English string to Japanese users instead of a translated error message.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -10096,6 +10112,9 @@ msgstr "PDF生成時にレポートスケジュールの実行が失敗しまし
msgid "Report Schedule execution failed when generating a screenshot."
msgstr "スクリーンショット生成時にレポートスケジュールの実行が失敗しました。"
+msgid "Report Schedule execution failed when generating an xlsx."
+msgstr ""
+
msgid "Report Schedule execution got an unexpected error."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Japanese translation</b></div>
<div id="fix">
Empty `msgstr` at line 10116 causes English fallback. This error is thrown
by `ReportScheduleXlsxFailedError` in `exceptions.py` and displayed to users
when XLSX report generation fails.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -11327,6 +11350,9 @@ msgstr ""
msgid "Send as CSV"
msgstr "CSVとして送信"
+msgid "Send as Excel"
+msgstr ""
+
msgid "Send as PDF"
msgstr "PDFとして送信"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Japanese translation</b></div>
<div id="fix">
Empty `msgstr` at line 11354 causes English fallback. This label is used in
`AlertReportModal.tsx:225` and `AlertReportModal.test.tsx:770` as a dropdown
option, so Japanese users will see 'Send as Excel' in English.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -206,6 +206,10 @@ msgstr "%(dialect)s به دلایل امنیتی نمیتواند به عنو
msgid "%(label)s file"
msgstr "فایل %(type)s"
+#, fuzzy, python-format
+msgid "%(name)s.%(extension)s"
+msgstr "ابعاد"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect translation placeholder</b></div>
<div id="fix">
The translation 'ابعاد' (dimensions) has no semantic relation to the msgid
'%(name)s.%(extension)s' which represents a filename with extension. Users will
see nonsensical output.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -12203,6 +12229,10 @@ msgstr ""
msgid "Send as CSV"
msgstr "بهعنوان CSV ارسال کنید"
+#, fuzzy
+msgid "Send as Excel"
+msgstr "متن را ارسال کنید"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Fuzzy translation with imprecise msgstr</b></div>
<div id="fix">
The `#, fuzzy` flag indicates this translation is uncertain and needs
review. Combined with an imprecise msgstr that drops the 'Excel' format
specification, Persian users will see misleading text. Either provide an
accurate translation and remove the fuzzy flag, or leave msgstr empty with a
clear comment explaining the pending translation.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -6312,6 +6320,10 @@ msgstr "مثال"
msgid "Examples"
msgstr "نمونهها"
+#, fuzzy
+msgid "Excel (XLSX) attached in email"
+msgstr "فرمتشده CSV در ایمیل پیوست شده است"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong file format in translation</b></div>
<div id="fix">
The translation incorrectly says 'CSV' instead of 'XLSX'. The msgid
specifically mentions 'Excel (XLSX)' not 'CSV'.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -10978,6 +11000,10 @@ msgstr "مقادیر کنترل مورد نیاز حذف شدهاند"
msgid "Resample"
msgstr "نمونهبرداری مجدد"
+#, python-format
+msgid "Resample method '%(method)s' is not supported."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Empty msgstr for user-facing error messages</b></div>
<div id="fix">
Three new translation entries have empty msgstr values (lines 11005, 15397,
15403). These error messages from `superset/viz.py` will display in English to
Persian users at runtime unless translated. Consider providing translations or
adding translator notes explaining the status.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -932,6 +936,10 @@ msgstr "در حین ساخت csv، یک تایم اوت رخ داد."
msgid "A timeout occurred while generating a dataframe."
msgstr "در حین تولید یک دیتافریم، یک تایم اوت رخ داد."
+#, fuzzy
+msgid "A timeout occurred while generating an xlsx."
+msgstr "در حین ساخت csv، یک تایم اوت رخ داد."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong file format in translation</b></div>
<div id="fix">
The translation incorrectly says 'csv' instead of 'xlsx'. This message
should say 'A timeout occurred while generating an xlsx' not 'csv'.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/cs/LC_MESSAGES/messages.po:
##########
@@ -6346,6 +6353,9 @@ msgstr "Příklad"
msgid "Examples"
msgstr "Příklady"
+msgid "Excel (XLSX) attached in email"
+msgstr ""
+
#, fuzzy
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete translation introduced</b></div>
<div id="fix">
Removing `fuzzy` flag while leaving `msgstr` empty marks this as translated
with an empty string. Users will see a blank email attachment description
instead of the English source text or a proper Czech translation.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/cs/LC_MESSAGES/messages.po:
##########
@@ -965,6 +969,9 @@ msgstr "Při generování CSV došlo k vypršení časového
limitu."
msgid "A timeout occurred while generating a dataframe."
msgstr "Při generování datového rámce došlo k vypršení časového limitu."
+msgid "A timeout occurred while generating an xlsx."
+msgstr ""
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete translation introduced</b></div>
<div id="fix">
Removing `fuzzy` flag while leaving `msgstr` empty causes this entry to be
marked as translated with an empty string. Per `build_translation_index.py`
logic, empty msgstr without fuzzy flag = 'translated' (indexed as empty
string). Czech users will see a blank instead of either the English fallback or
a proper translation.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/cs/LC_MESSAGES/messages.po:
##########
@@ -10899,6 +10915,9 @@ msgstr "Provedení plánu reportu selhalo při generování
PDF."
msgid "Report Schedule execution failed when generating a screenshot."
msgstr "Provedení plánu reportu selhalo při generování snímku obrazovky."
+msgid "Report Schedule execution failed when generating an xlsx."
+msgstr ""
+
msgid "Report Schedule execution got an unexpected error."
msgstr "Při provádění plánu reportu došlo k neočekávané chybě."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete translation introduced</b></div>
<div id="fix">
Adding empty `msgstr` without fuzzy flag marks this as translated with an
empty string. Users will see a blank error message when XLSX report generation
times out instead of the English source text or proper Czech translation.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/cs/LC_MESSAGES/messages.po:
##########
@@ -12215,6 +12238,9 @@ msgstr ""
msgid "Send as CSV"
msgstr "Odeslat jako CSV"
+msgid "Send as Excel"
+msgstr ""
+
msgid "Send as PDF"
msgstr "Odeslat jako PDF"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete translation introduced</b></div>
<div id="fix">
Adding empty `msgstr` without fuzzy flag marks this as translated with an
empty string. Users will see a blank label in the report delivery options UI
instead of the English source text or proper Czech translation.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/tr/LC_MESSAGES/messages.po:
##########
@@ -180,6 +180,10 @@ msgstr ""
msgid "%(label)s file"
msgstr ""
+#, python-format
+msgid "%(name)s.%(extension)s"
+msgstr "%(name)s.%(extension)s"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Translation regression: valid Turkish lost</b></div>
<div id="fix">
This change regresses a valid Turkish translation. The previous value "son
kullanılanlar" (meaning "recently used") was a proper Turkish translation that
is now lost. Replacing it with the English msgid copy means users see
untranslated text instead of Turkish. Either restore the original translation
with the fuzzy flag, or provide a proper Turkish translation.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/tr/LC_MESSAGES/messages.po (lines 183-185) ---
183: #, fuzzy, python-format
184: msgid "%(name)s.%(extension)s"
185: -msgstr "%(name)s.%(extension)s"
185: +msgstr "son kullanılanlar"
```
</div>
</details>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/it/LC_MESSAGES/messages.po:
##########
@@ -182,6 +182,10 @@ msgstr ""
msgid "%(label)s file"
msgstr ""
+#, python-format
+msgid "%(name)s.%(extension)s"
+msgstr "%(name)s.%(extension)s"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Placeholder translation for file name</b></div>
<div id="fix">
The `msgstr` for `%(name)s.%(extension)s` uses the English placeholder
instead of an Italian translation. While this is a valid fallback pattern in
gettext, Italian users will see English text. Consider providing a proper
Italian translation or at minimum prefixing with "file" to indicate context.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/it/LC_MESSAGES/messages.po:
##########
@@ -875,6 +879,9 @@ msgstr "Errore nel recupero dei metadati della tabella"
msgid "A timeout occurred while generating a dataframe."
msgstr "Errore nel creare il datasource"
+msgid "A timeout occurred while generating an xlsx."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Untranslated xlsx timeout error</b></div>
<div id="fix">
The `msgstr` for the xlsx timeout error is empty, leaving Italian users with
untranslated English text. Similar timeout messages in this file have proper
Italian translations (e.g., 'Errore nel recupero dei metadati della tabella'
for csv, 'Errore nel creare il datasource' for dataframe). This inconsistency
should be addressed.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/nl/LC_MESSAGES/messages.po:
##########
@@ -6416,6 +6423,9 @@ msgstr "Voorbeeld"
msgid "Examples"
msgstr "Voorbeelden"
+msgid "Excel (XLSX) attached in email"
+msgstr ""
+
#, fuzzy
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Dutch translation</b></div>
<div id="fix">
Removing the fuzzy flag exposes an empty msgstr, causing 'Excel (XLSX)
attached in email' to display untranslated to Dutch users. Line 6427 should
contain the Dutch equivalent.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/nl/LC_MESSAGES/messages.po:
##########
@@ -919,6 +923,9 @@ msgstr "Er is een time-out opgetreden tijdens het genereren
van een csv."
msgid "A timeout occurred while generating a dataframe."
msgstr "Er is een time-out opgetreden tijdens het genereren van een dataframe."
+msgid "A timeout occurred while generating an xlsx."
+msgstr ""
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Dutch translation</b></div>
<div id="fix">
Removing the fuzzy flag exposes an empty msgstr, causing the English text to
display to Dutch users. Line 927 should contain a Dutch translation following
the established pattern from lines 918-924 (e.g., "Er is een time-out
opgetreden tijdens het genereren van een xlsx-bestand.").
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/nl/LC_MESSAGES/messages.po:
##########
@@ -11042,6 +11058,9 @@ msgstr ""
"Rapportage planning uitvoering mislukt bij het genereren van een "
"screenshot."
+msgid "Report Schedule execution failed when generating an xlsx."
+msgstr ""
+
msgid "Report Schedule execution got an unexpected error."
msgstr "Rapportage planning uitvoering kreeg een onverwachte fout."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Dutch translation</b></div>
<div id="fix">
Removing the fuzzy flag exposes an empty msgstr at line 11062, causing the
English error message to display to Dutch users. The translation should follow
the established pattern from line 11057-11059 (e.g., "Rapportage planning
uitvoering mislukt bij het genereren van een xlsx-bestand.").
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/nl/LC_MESSAGES/messages.po:
##########
@@ -12382,6 +12405,9 @@ msgstr ""
msgid "Send as CSV"
msgstr "Verstuur als CSV"
+msgid "Send as Excel"
+msgstr ""
+
#, fuzzy
msgid "Send as PDF"
msgstr "Verstuur als PNG"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Dutch translation</b></div>
<div id="fix">
Removing the fuzzy flag exposes an empty msgstr at line 12409, causing 'Send
as Excel' to display untranslated. Following the established pattern from line
12405-12406 ("Verstuur als CSV"), line 12409 should be "Verstuur als Excel".
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/zh_TW/LC_MESSAGES/messages.po:
##########
@@ -188,6 +188,10 @@ msgstr "出於安全原因，%(dialect)s SQLite 資料庫不能用作數據源
msgid "%(label)s file"
msgstr ""
+#, fuzzy, python-format
+msgid "%(name)s.%(extension)s"
+msgstr "维度"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Translation: Incorrect msgstr</b></div>
<div id="fix">
The translation '维度' (dimension) is semantically incorrect for a filename
pattern like '%(name)s.%(extension)s'. This will display confusing output to
users. The translation should reflect a filename pattern.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/zh_TW/LC_MESSAGES/messages.po:
##########
@@ -885,6 +889,10 @@ msgstr "生成 CSV 時超時。"
msgid "A timeout occurred while generating a dataframe."
msgstr "生成數據超時"
+#, fuzzy
+msgid "A timeout occurred while generating an xlsx."
+msgstr "生成 CSV 時超時。"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Translation: Copy-paste error</b></div>
<div id="fix">
Copy-paste error: the translation references CSV but the msgid is for xlsx.
Users will see incorrect message '生成 CSV 時超時' when an xlsx timeout occurs.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/zh_TW/LC_MESSAGES/messages.po:
##########
@@ -6290,6 +6298,10 @@ msgstr "例子"
msgid "Examples"
msgstr "示例"
+#, fuzzy
+msgid "Excel (XLSX) attached in email"
+msgstr "郵件中附上格式化好的CSV"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Translation: Copy-paste error</b></div>
<div id="fix">
Copy-paste error: the translation references CSV but the msgid is 'Excel
(XLSX) attached in email'. Users will see incorrect message about CSV when
Excel is attached.
</div>
</div>
<small><i>Code Review Run #64f414</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
