bito-code-review[bot] commented on code in PR #40885: URL: https://github.com/apache/superset/pull/40885#discussion_r3382195656
########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -969,6 +973,9 @@ msgstr "Se ha agotado el tiempo de espera al generar un CSV." msgid "A timeout occurred while generating a dataframe." msgstr "Se ha agotado el tiempo de espera al generar un marco de datos." +msgid "A timeout occurred while generating an xlsx." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Spanish translation</b></div> <div id="fix"> The `#, fuzzy` flag was removed, indicating this translation is approved for production, but `msgstr` remains empty. Spanish users will see the untranslated English string in the UI. Compare with the CSV variant at line 970 which has a proper translation. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -12573,6 +12596,9 @@ msgstr "" msgid "Send as CSV" msgstr "Enviar como CSV" +msgid "Send as Excel" +msgstr "" + #, fuzzy msgid "Send as PDF" msgstr "Enviar como PNG" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Inconsistent fuzzy flag and translation state</b></div> <div id="fix"> The diff claims to remove #, fuzzy from 'Send as Excel' (line 12602), but the actual file shows #, fuzzy is on 'Send as PDF' (line 12602-12603). The fuzzy flag was not removed from the intended entry. Additionally, 'Send as Excel' remains untranslated while adjacent entries ('Send as CSV', 'Send as PNG', 'Send as text') are fully translated, creating inconsistency. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -6290,6 +6297,9 @@ msgstr "例子" msgid "Examples" msgstr "示例" +msgid "Excel (XLSX) attached in email" +msgstr "" + Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Quality: Fuzzy Flag Removal</b></div> <div id="fix"> Removing the `#, fuzzy` flag without providing a proper translation causes this entry to be treated as untranslated. The original fuzzy translation '郵件中附上格式化好的CSV' was incorrect (mentions CSV instead of Excel) but at least provided a translation. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -6595,6 +6602,9 @@ msgstr "Przykład" msgid "Examples" msgstr "Przykłady" +msgid "Excel (XLSX) attached in email" +msgstr "" + Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect CSV translation replaced with empty</b></div> <div id="fix"> Empty translation for 'Excel (XLSX) attached in email' will display English text. The old fuzzy translation incorrectly mentioned CSV format. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -234,6 +234,10 @@ msgstr "" msgid "%(label)s file" msgstr "%(type)s do Arquivo" +#, fuzzy, python-format +msgid "%(name)s.%(extension)s" +msgstr "Dimensões" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Missing Format Variables</b></div> <div id="fix"> The translation 'Dimensões' (Dimensions) ignores both `%(name)s` and `%(extension)s` placeholders. When rendered, users will see 'Dimensões' instead of the actual file name and extension. The translation must preserve both format variables. </div> </div> <small><i>Code Review Run #64f414</i></small> </div><div> <div id="suggestion"> <div id="issue"><b>Empty translation for format string</b></div> <div id="fix"> The `msgstr` for `%(name)s.%(extension)s` was changed from 'Dimensões' to empty. 'Dimensões' was an incorrect translation from a fuzzy entry, but replacing it with empty string removes any user-facing text. Provide a proper Portuguese translation or copy the msgid if no translation is available. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -885,6 +889,9 @@ msgstr "生成 CSV 時超時。" msgid "A timeout occurred while generating a dataframe." msgstr "生成數據超時" +msgid "A timeout occurred while generating an xlsx." +msgstr "" + Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Quality: Fuzzy Flag Removal</b></div> <div id="fix"> Removing the `#, fuzzy` flag without providing a proper translation causes this entry to be treated as untranslated. The original fuzzy translation '生成 CSV 時超時。' was incorrect (mentions CSV instead of xlsx) but at least provided a translation. The new empty state provides no translation at all. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pl/LC_MESSAGES/messages.po: ########## @@ -960,6 +964,9 @@ msgstr "Wystąpiło przekroczenie czasu podczas generowania pliku CSV." msgid "A timeout occurred while generating a dataframe." msgstr "Wystąpiło przekroczenie czasu podczas generowania ramki danych." +msgid "A timeout occurred while generating an xlsx." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect translation replaced with empty</b></div> <div id="fix"> Empty translation for XLSX timeout message will display English text to Polish users. The old translation incorrectly mentioned CSV; provide proper Polish translation for XLSX format. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -12302,6 +12325,9 @@ msgstr "" msgid "Send as CSV" msgstr "發送為CSV" +msgid "Send as Excel" +msgstr "" + #, fuzzy msgid "Send as PDF" msgstr "發送PNG" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Quality: Fuzzy Flag Removal</b></div> <div id="fix"> Removing the `#, fuzzy` flag without providing a proper translation causes this entry to be treated as untranslated. The original fuzzy translation '發送文本' was incorrect (mentions text instead of PDF) but at least provided a translation. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -188,6 +188,10 @@ msgstr "出於安全原因，%(dialect)s SQLite 資料庫不能用作數據源 msgid "%(label)s file" msgstr "" +#, python-format +msgid "%(name)s.%(extension)s" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Quality: Fuzzy Flag Removal</b></div> <div id="fix"> Removing the `#, fuzzy` flag without providing a proper translation causes this entry to be treated as untranslated (null in the translation index). The fuzzy flag signals that the translation needs review; removing it without adding a reviewed translation degrades translation quality. Either provide a proper translation or retain the fuzzy marker. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -10952,6 +10968,9 @@ msgstr "在生成 CSV 文件時，報告計劃執行失敗。" msgid "Report Schedule execution failed when generating a screenshot." msgstr "在生成螢幕截圖時，報告計劃執行失敗。" +msgid "Report Schedule execution failed when generating an xlsx." +msgstr "" + msgid "Report Schedule execution got an unexpected error." msgstr "報表計劃執行遇到意外錯誤。" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Quality: Fuzzy Flag Removal</b></div> <div id="fix"> Removing the `#, fuzzy` flag without providing a proper translation causes this entry to be treated as untranslated. The original fuzzy translation '在生成 CSV 文件時，報告計劃執行失敗。' was incorrect (mentions CSV instead of xlsx) but at least provided a translation. </div> </div> <small><i>Code Review Run #561edf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
