bito-code-review[bot] commented on code in PR #40885: URL: https://github.com/apache/superset/pull/40885#discussion_r3379999833
########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -12302,6 +12328,10 @@ msgstr "" msgid "Send as CSV" msgstr "發送為CSV" +#, fuzzy +msgid "Send as Excel" +msgstr "發送文本" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation: Copy-paste error</b></div> <div id="fix"> Copy-paste error: the translation says '發送文本' (send as text) but the msgid is 'Send as Excel'. Users will see incorrect message when selecting Excel export. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -10952,6 +10970,10 @@ msgstr "在生成 CSV 文件時，報告計劃執行失敗。" msgid "Report Schedule execution failed when generating a screenshot." msgstr "在生成螢幕截圖時，報告計劃執行失敗。" +#, fuzzy +msgid "Report Schedule execution failed when generating an xlsx." +msgstr "在生成 CSV 文件時，報告計劃執行失敗。" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation: Copy-paste error</b></div> <div id="fix"> Copy-paste error: the translation references CSV but the msgid is 'Report Schedule execution failed when generating an xlsx.' Users will see incorrect message about CSV when xlsx generation fails. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -12692,6 +12720,10 @@ msgstr "" msgid "Send as CSV" msgstr "Enviar como CSV" +#, fuzzy +msgid "Send as Excel" +msgstr "Enviar como texto" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation mismatch</b></div> <div id="fix"> Mistranslation: 'Send as Excel' UI action incorrectly displays as 'Send as text' in Spanish. Users may not find Excel export option. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -6584,6 +6592,10 @@ msgstr "Ejemplo" msgid "Examples" msgstr "Ejemplos" +#, fuzzy +msgid "Excel (XLSX) attached in email" +msgstr "CSV formateado adjunto en el correo electrónico" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation mismatch</b></div> <div id="fix"> Mistranslation: 'Excel (XLSX)' message incorrectly says 'CSV' in Spanish. Email attachment description will be misleading. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -969,6 +973,10 @@ msgstr "Se ha agotado el tiempo de espera al generar un CSV." msgid "A timeout occurred while generating a dataframe." msgstr "Se ha agotado el tiempo de espera al generar un marco de datos." +#, fuzzy +msgid "A timeout occurred while generating an xlsx." +msgstr "Se ha agotado el tiempo de espera al generar un CSV." Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation mismatch</b></div> <div id="fix"> Mistranslation: msgid references 'xlsx' but msgstr incorrectly says 'CSV'. Users will see wrong file type in error message. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -6286,6 +6294,10 @@ msgstr "例子" msgid "Examples" msgstr "示例" +#, fuzzy +msgid "Excel (XLSX) attached in email" +msgstr "邮件中附上格式化好的CSV" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CSV/XLSX format mismatch in translation</b></div> <div id="fix"> Translation mismatch: msgid mentions 'Excel (XLSX)' but msgstr says 'CSV' (逗号分割文件). Should use 'XLSX文件' (XLSX file) instead to match the original message. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -11322,6 +11340,12 @@ msgstr "" "Se ha producido un error en la ejecución de la programación de informes " "al generar una captura de pantalla." +#, fuzzy +msgid "Report Schedule execution failed when generating an xlsx." +msgstr "" +"Se ha producido un error en la ejecución de la programación de informes " +"al generar un CSV." Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation mismatch</b></div> <div id="fix"> Mistranslation: Report schedule failure message incorrectly references 'CSV' instead of 'xlsx'. Users see wrong format in error. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -6726,6 +6738,12 @@ msgstr "" msgid "File settings" msgstr "过滤器设置" +#, python-format +msgid "" +"File size %(size)s bytes exceeds the maximum allowed upload size of " +"%(max_size)s bytes" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty translation string for error message</b></div> <div id="fix"> Empty translation string: msgid 'File size %(size)s bytes exceeds the maximum allowed upload size of %(max_size)s bytes' has empty msgstr. Users will see the raw English error message. Add appropriate Chinese translation. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -10939,6 +10957,10 @@ msgstr "在生成 CSV 文件时，报告计划执行失败。" msgid "Report Schedule execution failed when generating a screenshot." msgstr "在生成屏幕截图时，报告计划执行失败。" +#, fuzzy +msgid "Report Schedule execution failed when generating an xlsx." +msgstr "在生成 CSV 文件时，报告计划执行失败。" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect file format in error message</b></div> <div id="fix"> Translation mismatch: msgid specifies 'xlsx' but msgstr incorrectly says 'CSV 文件'. Compare with line 10947-10948 where 'csv' correctly translates to 'CSV 文件'. This entry should use 'XLSX 文件'. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -886,6 +890,10 @@ msgstr "生成CSV时超时。" msgid "A timeout occurred while generating a dataframe." msgstr "生成数据超时" +#, fuzzy +msgid "A timeout occurred while generating an xlsx." +msgstr "生成CSV时超时。" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect file format translation</b></div> <div id="fix"> Translation mismatch: msgid references 'xlsx' but msgstr incorrectly uses 'CSV'. Following the existing pattern 'A timeout occurred while generating a csv.' → '生成CSV时超时。', this entry should read '生成XLSX时超时。' for consistency and correctness. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -11033,6 +11055,10 @@ msgstr "必需的控件值已被移除" msgid "Resample" msgstr "重新采样" +#, python-format +msgid "Resample method '%(method)s' is not supported." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty translation string for validation error</b></div> <div id="fix"> Empty translation string: msgid 'Resample method \'%(method)s\' is not supported.' has empty msgstr. Users will see raw English error message. Add appropriate Chinese translation following the pattern of similar error messages in the file. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -234,6 +234,10 @@ msgstr "" msgid "%(label)s file" msgstr "%(type)s do Arquivo" +#, fuzzy, python-format +msgid "%(name)s.%(extension)s" +msgstr "Dimensões" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Missing Format Variables</b></div> <div id="fix"> The translation 'Dimensões' (Dimensions) ignores both `%(name)s` and `%(extension)s` placeholders. When rendered, users will see 'Dimensões' instead of the actual file name and extension. The translation must preserve both format variables. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -967,6 +971,10 @@ msgstr "Ocorreu um tempo limite ao gerar um arquivo csv." msgid "A timeout occurred while generating a dataframe." msgstr "Ocorreu um timeout durante a geração de um dataframe." +#, fuzzy +msgid "A timeout occurred while generating an xlsx." +msgstr "Ocorreu um tempo limite ao gerar um arquivo csv." Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Type Mismatch</b></div> <div id="fix"> The translation says 'arquivo csv' but the source message is about 'xlsx' files. This mismatch will confuse users seeing an xlsx-related error message that mentions csv. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -12289,6 +12315,10 @@ msgstr "" msgid "Send as CSV" msgstr "发送为CSV" +#, fuzzy +msgid "Send as Excel" +msgstr "发送文本" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect action verb in translation</b></div> <div id="fix"> Translation mismatch: msgid 'Send as Excel' is translated as '发送文本' (Send text). Compare with 'Send as CSV' at line 12315 which correctly translates to '发送为CSV'. This entry should use '发送为Excel' for consistency. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -11217,6 +11235,10 @@ msgstr "" "A execução do agendamento do relatório falhou ao gerar uma captura de " "tela." +#, fuzzy +msgid "Report Schedule execution failed when generating an xlsx." +msgstr "A execução do Report Schedule falhou ao gerar um arquivo csv." Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Type Mismatch</b></div> <div id="fix"> The translation says 'arquivo csv' but the source is about 'xlsx' files. Users will see incorrect format type in report schedule error messages. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -6984,6 +6996,12 @@ msgstr "" msgid "File settings" msgstr "Configurações de filtro" +#, python-format +msgid "" +"File size %(size)s bytes exceeds the maximum allowed upload size of " +"%(max_size)s bytes" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty Translation String</b></div> <div id="fix"> The translation is empty (msgstr ""), so users will see the English error message instead of Portuguese. This is a user-facing error message that should be translated. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -11309,6 +11331,10 @@ msgstr "Os valores de controle necessários foram eliminados" msgid "Resample" msgstr "Reamostragem" +#, python-format +msgid "Resample method '%(method)s' is not supported." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty Translation String</b></div> <div id="fix"> The translation is empty (msgstr ""), so users will see the English error message instead of Portuguese. This is a user-facing error message that should be translated. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -12573,6 +12599,10 @@ msgstr "" msgid "Send as CSV" msgstr "Enviar como CSV" +#, fuzzy +msgid "Send as Excel" +msgstr "Enviar como texto" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Semantic Mismatch</b></div> <div id="fix"> The translation says 'Enviar como texto' (Send as text) but the source is 'Send as Excel'. Users will see incorrect format type in export options. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -6540,6 +6548,10 @@ msgstr "Exemplo" msgid "Examples" msgstr "Exemplos" +#, fuzzy +msgid "Excel (XLSX) attached in email" +msgstr "CSV formatado anexado no e-mail" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation Type Mismatch</b></div> <div id="fix"> The translation says 'CSV formatado anexado no e-mail' but the source is 'Excel (XLSX) attached in email'. Users will see incorrect format type in email notification settings. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -15795,6 +15825,18 @@ msgstr "Para obter um URL legível para seu painel" msgid "Token Request URI" msgstr "" +#, python-format +msgid "" +"Too many sub-slices requested. The maximum allowed is %(max)s, but " +"%(count)s were requested." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty Translation String</b></div> <div id="fix"> The translation is empty (msgstr ""), so users will see the English error message instead of Portuguese. This is a user-facing error message that should be translated. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -956,6 +960,9 @@ msgstr "Beim Generieren einer CSV-Datei ist ein Timeout aufgetreten." msgid "A timeout occurred while generating a dataframe." msgstr "Beim Generieren eines Datenextrakts ist ein Timeout aufgetreten." +msgid "A timeout occurred while generating an xlsx." +msgstr "" + Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect semantic translation</b></div> <div id="fix"> The old fuzzy entry for 'xlsx' contained the wrong translation text (CSV message). The removed line 965 'Beim Generieren einer CSV-Datei ist ein Timeout aufgetreten.' is semantically wrong for xlsx and creates incorrect German user output when xlsx timeout occurs. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/pt_BR/LC_MESSAGES/messages.po: ########## @@ -15795,6 +15825,18 @@ msgstr "Para obter um URL legível para seu painel" msgid "Token Request URI" msgstr "" +#, python-format +msgid "" +"Too many sub-slices requested. The maximum allowed is %(max)s, but " +"%(count)s were requested." +msgstr "" + +#, python-format +msgid "" +"Too many time comparisons requested. The maximum allowed is %(max)s, but " +"%(count)s were requested." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty Translation String</b></div> <div id="fix"> The translation is empty (msgstr ""), so users will see the English error message instead of Portuguese. This is a user-facing error message that should be translated. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -6460,6 +6467,9 @@ msgstr "Beispiel" msgid "Examples" msgstr "Beispiele" +msgid "Excel (XLSX) attached in email" +msgstr "" + #, fuzzy Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing translation after defuzzy</b></div> <div id="fix"> Removing the fuzzy flag for 'Excel (XLSX) attached in email' without providing a German translation creates empty output. The removed 'Formatierte CSV-Datei in E-Mail angehängt' was incorrectly applied to xlsx. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/sk/LC_MESSAGES/messages.po: ########## @@ -958,6 +962,9 @@ msgstr "Pri generovanie CSV došlo k vypršenie časového limitu." msgid "A timeout occurred while generating a dataframe." msgstr "Pri generovanie dátového rámce došlo k vypršenie časového limitu." +msgid "A timeout occurred while generating an xlsx." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing XLSX translation</b></div> <div id="fix"> Empty `msgstr` for XLSX timeout message will display as blank text to Slovak users. Add proper translation following the pattern of adjacent entries (lines 962-963, 968-969). </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -6387,6 +6394,9 @@ msgstr "Exemple" msgid "Examples" msgstr "Exemples" +msgid "Excel (XLSX) attached in email" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incomplete translation fix</b></div> <div id="fix"> The `fuzzy` flag was removed but `msgstr` was left empty. Users will see English 'Excel (XLSX) attached in email' instead of French. This is a UI label used in ReportModal. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/fr/LC_MESSAGES/messages.po +++ b/superset/translations/fr/LC_MESSAGES/messages.po @@ -6394,7 +6394,8 @@ msgstr "Exemples" msgid "Excel (XLSX) attached in email" -msgstr "" +msgstr "Fichier Excel (XLSX) joint dans le courriel" msgid "Excel Export" ``` </div> </details> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/commands/report/execute.py: ########## @@ -552,6 +567,19 @@ def _get_csv_data(self) -> bytes: raise ReportScheduleCsvFailedError() return csv_data + def _get_xlsx_data(self) -> bytes: + try: + xlsx_data = self._get_chart_data(ChartDataResultFormat.XLSX) + except SoftTimeLimitExceeded as ex: + raise ReportScheduleXlsxTimeout() from ex + except Exception as ex: + raise ReportScheduleXlsxFailedError( + f"Failed generating xlsx {str(ex)}" + ) from ex + if not xlsx_data: + raise ReportScheduleXlsxFailedError() + return xlsx_data Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing timeout diagnostic logging</b></div> <div id="fix"> The `_get_xlsx_data` handler for `SoftTimeLimitExceeded` (line 573) lacks the elapsed-time logging that `_get_csv_data` provides. Without this, timeouts are harder to diagnose in production since operators won't know how long the operation ran. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/commands/report/execute.py +++ b/superset/commands/report/execute.py @@ -567,8 +567,13 @@ class BaseReportState: def _get_xlsx_data(self) -> bytes: try: + start_time = datetime.utcnow() xlsx_data = self._get_chart_data(ChartDataResultFormat.XLSX) except SoftTimeLimitExceeded as ex: + elapsed_seconds = (datetime.utcnow() - start_time).total_seconds() + logger.warning( + "XLSX generation timeout after %.2fs - execution_id: %s", + elapsed_seconds, + self._execution_id, + ) raise ReportScheduleXlsxTimeout() from ex except Exception as ex: raise ReportScheduleXlsxFailedError( ``` </div> </details> </div> <small><i>Code Review Run #077cf0</i></small> </div><div> <div id="suggestion"> <div id="issue"><b>Semantic duplication in diff</b></div> <div id="fix"> The new timing instrumentation in `_get_xlsx_data` (lines 575-580, 583-588) duplicates the exact pattern already present in `_get_csv_data` (lines 549-562). This creates maintenance risk where logging format changes require updates in two places. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/de/LC_MESSAGES/messages.po: ########## @@ -11127,6 +11143,9 @@ msgstr "" "Bericht-Ausführungsplan Die Ausführung des Zeitplans ist beim Generieren " "eines Screenshots fehlgeschlagen." +msgid "Report Schedule execution failed when generating an xlsx." +msgstr "" + msgid "Report Schedule execution got an unexpected error." msgstr "Unerwarteter Fehler bei der Ausführung des geplanten Berichts." Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing xlsx report failure translation</b></div> <div id="fix"> Empty translation for xlsx report failure leaves users without error context. The CSV translation was incorrectly applied to xlsx in the old fuzzy entry. </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -950,6 +954,9 @@ msgstr "Dépassement de délai lors de la génération d'un CSV." msgid "A timeout occurred while generating a dataframe." msgstr "Dépassement de délai lors de la génération d'une trame de données." +msgid "A timeout occurred while generating an xlsx." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incomplete translation fix</b></div> <div id="fix"> The `fuzzy` flag was removed but `msgstr` was left empty. Users will see English 'A timeout occurred while generating an xlsx.' instead of French. Compare with the correctly translated CSV variant at line 951-952 for the proper pattern. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/fr/LC_MESSAGES/messages.po +++ b/superset/translations/fr/LC_MESSAGES/messages.po @@ -954,7 +954,7 @@ msgstr "Dépassement de délai lors de la génération d'un CSV." msgid "A timeout occurred while generating a dataframe." msgstr "Dépassement de délai lors de la génération d'une trame de données." -msgid "A timeout occurred while generating an xlsx." +msgid "A timeout occurred while generating an xlsx." msgstr "" +msgstr "Dépassement de délai lors de la génération d'un fichier Excel." ``` </div> </details> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -12506,6 +12529,9 @@ msgstr "" msgid "Send as CSV" msgstr "Envoyer comme CSV" +msgid "Send as Excel" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incomplete translation fix</b></div> <div id="fix"> The `fuzzy` flag was removed but `msgstr` was left empty. Users will see English 'Send as Excel' instead of French. This is a UI label used in AlertReportModal. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/superset/translations/fr/LC_MESSAGES/messages.po +++ b/superset/translations/fr/LC_MESSAGES/messages.po @@ -12529,7 +12529,8 @@ msgstr "" msgid "Send as Excel" -msgstr "" +msgstr "Envoyer comme Excel" msgid "Send as PDF" ``` </div> </details> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ko/LC_MESSAGES/messages.po: ########## @@ -870,6 +874,9 @@ msgstr "데이터 베이스 목록을 가져오는 도중 에러가 발생하였 msgid "A timeout occurred while generating a dataframe." msgstr "데이터 베이스 목록을 가져오는 도중 에러가 발생하였습니다." +msgid "A timeout occurred while generating an xlsx." +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty Translation String Regression</b></div> <div id="fix"> Please restore the Korean translation for 'A timeout occurred while generating an xlsx.' by replacing the empty msgstr with "데이터 베이스 목록을 가져오는 도중 에러가 발생하였습니다.". </div> </div> <small><i>Code Review Run #64f414</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
