bito-code-review[bot] commented on code in PR #40912:
URL: https://github.com/apache/superset/pull/40912#discussion_r3382807436
##########
superset/dashboards/api.py:
##########
@@ -524,6 +527,126 @@ def get(
)
return self.response(200, result=result)
+ @expose("/<id_or_slug>/lineage", methods=("GET",))
+ @protect()
+ @safe
+ @statsd_metrics
+ @with_dashboard
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing @<!-- -->handle_api_exception decorator</b></div>
<div id="fix">
Add the missing `@handle_api_exception` decorator to the `lineage` endpoint,
placing it immediately after `@protect()` and before `@statsd_metrics` to align
with other endpoints like `get_datasets`.
</div>
</div>
<small><i>Code Review Run #9dcb5b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/src/features/lineage/LineageView.tsx:
##########
@@ -0,0 +1,728 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { FC, useMemo, useState, useCallback } from 'react';
+import { t } from '@apache-superset/core/translation';
+import { styled, useTheme } from '@apache-superset/core/theme';
+import { Empty, Loading } from '@superset-ui/core/components';
+import { Button } from '@superset-ui/core/components';
+import { ResourceStatus } from 'src/hooks/apiResources/apiResources';
+import type { Resource } from 'src/hooks/apiResources/apiResources';
+import type {
+ DatasetLineage,
+ ChartLineage,
+ DashboardLineage,
+ ChartEntity,
+ DashboardEntity,
+ DatasetEntity,
+ DatabaseEntity,
+} from 'src/hooks/apiResources/lineage';
+import Echart from
'../../../plugins/plugin-chart-echarts/src/components/Echart';
+import type { EChartsCoreOption } from 'echarts/core';
+
+const LineageContainer = styled.div`
+ display: flex;
+ flex-direction: column;
+ width: 100%;
+ height: 100%;
+`;
+
+const Legend = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ justify-content: center;
+ align-items: center;
+ gap: ${theme.sizeUnit * 4}px;
+ padding: ${theme.sizeUnit * 3}px;
+ background-color: ${theme.colorBgLayout};
+ border-bottom: 1px solid ${theme.colorBorder};
+ `}
+`;
+
+const LegendItem = styled.div<{ color: string }>`
+ ${({ theme, color }) => `
+ display: flex;
+ align-items: center;
+ gap: ${theme.sizeUnit * 2}px;
+ font-size: ${theme.fontSizeSM}px;
+ color: ${theme.colorText};
+
+ &::before {
+ content: '';
+ width: 12px;
+ height: 12px;
+ border-radius: 2px;
+ background-color: ${color};
+ }
+ `}
+`;
+
+const DetailsPanel = styled.div`
+ ${({ theme }) => `
+ padding: ${theme.sizeUnit * 4}px;
+ background-color: ${theme.colorBgLayout};
+ border-top: 1px solid ${theme.colorBorder};
+ min-height: 120px;
+ `}
+`;
+
+const DetailsPanelHeader = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ justify-content: space-between;
+ align-items: center;
+ margin-bottom: ${theme.sizeUnit * 3}px;
+ `}
+`;
+
+const DetailsPanelActions = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ gap: ${theme.sizeUnit * 2}px;
+ `}
+`;
+
+const DetailsPanelTitle = styled.h4`
+ ${({ theme }) => `
+ margin: 0;
+ font-size: ${theme.fontSizeLG}px;
+ font-weight: ${theme.fontWeightStrong};
+ color: ${theme.colorText};
+ `}
+`;
+
+const DetailsPanelContent = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ flex-direction: column;
+ gap: ${theme.sizeUnit * 2}px;
+ `}
+`;
+
+const DetailRow = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ gap: ${theme.sizeUnit * 2}px;
+ font-size: ${theme.fontSizeSM}px;
+ color: ${theme.colorText};
+ `}
+`;
+
+const DetailLabel = styled.span`
+ ${({ theme }) => `
+ font-weight: ${theme.fontWeightStrong};
+ min-width: 100px;
+ `}
+`;
+
+const DetailValue = styled.span`
+ ${({ theme }) => `
+ color: ${theme.colorTextSecondary};
+ `}
+`;
+
+type NodeType = 'database' | 'dataset' | 'chart' | 'dashboard';
+
+type NodeDetails = {
+ name: string;
+ type: NodeType;
+ id?: number;
+ additionalInfo?: Record<string, any>;
+};
+
+// Build a stable, unique graph identity for a node so that entities sharing
the
+// same display name (e.g. two charts with identical titles) never collapse
into
+// a single Sankey node. The human-readable name is kept separately as the
label.
+const nodeKey = (type: NodeType, id?: number, name?: string): string =>
+ id != null ? `${type}:${id}` : `${type}:${name ?? ''}`;
+
+type LineageViewProps = {
+ lineageResource:
+ | Resource<DatasetLineage>
+ | Resource<ChartLineage>
+ | Resource<DashboardLineage>;
+ entityType: 'dataset' | 'chart' | 'dashboard';
+};
+
+const LineageView: FC<LineageViewProps> = ({ lineageResource, entityType }) =>
{
+ const theme = useTheme();
+ const [selectedNode, setSelectedNode] = useState<NodeDetails | null>(null);
+
+ // Create a mapping of node names to their details
+ const nodeDetailsMap = useMemo(() => {
+ if (
+ lineageResource.status !== ResourceStatus.Complete ||
+ !lineageResource.result
+ ) {
+ return new Map<string, NodeDetails>();
+ }
+
+ const data = lineageResource.result;
+ const map = new Map<string, NodeDetails>();
+
+ if (entityType === 'dataset' && 'dataset' in data) {
+ const { dataset, upstream, downstream } = data as DatasetLineage;
+
+ // Add current dataset
+ map.set(nodeKey('dataset', dataset.id, dataset.name), {
+ name: dataset.name,
+ type: 'dataset',
+ id: dataset.id,
+ additionalInfo: {
+ schema: dataset.schema,
+ table_name: dataset.table_name,
+ database_name: dataset.database_name,
+ },
+ });
+
+ // Add upstream database
+ if (upstream?.database) {
+ map.set(
+ nodeKey(
+ 'database',
+ upstream.database.id,
+ upstream.database.database_name,
+ ),
+ {
+ name: upstream.database.database_name,
+ type: 'database',
+ id: upstream.database.id,
+ },
+ );
+ }
+
+ // Add downstream charts
+ if (downstream?.charts?.result) {
+ downstream.charts.result.forEach((chart: ChartEntity) => {
+ map.set(nodeKey('chart', chart.id, chart.slice_name), {
+ name: chart.slice_name,
+ type: 'chart',
+ id: chart.id,
+ additionalInfo: {
+ viz_type: chart.viz_type,
+ },
+ });
+ });
+ }
+
+ // Add downstream dashboards
+ if (downstream?.dashboards?.result) {
+ downstream.dashboards.result.forEach((dashboard: DashboardEntity) => {
+ map.set(nodeKey('dashboard', dashboard.id, dashboard.title), {
+ name: dashboard.title,
+ type: 'dashboard',
+ id: dashboard.id,
+ additionalInfo: {
+ slug: dashboard.slug,
+ },
+ });
+ });
+ }
+ } else if (entityType === 'chart' && 'chart' in data) {
+ const { chart, upstream, downstream } = data as ChartLineage;
+
+ // Add current chart
+ map.set(nodeKey('chart', chart.id, chart.slice_name), {
+ name: chart.slice_name,
+ type: 'chart',
+ id: chart.id,
+ additionalInfo: {
+ viz_type: chart.viz_type,
+ },
+ });
+
+ // Add upstream dataset
+ if (upstream?.dataset) {
+ map.set(
+ nodeKey('dataset', upstream.dataset.id, upstream.dataset.name),
+ {
+ name: upstream.dataset.name,
+ type: 'dataset',
+ id: upstream.dataset.id,
+ additionalInfo: {
+ schema: upstream.dataset.schema,
+ table_name: upstream.dataset.table_name,
+ },
+ },
+ );
+ }
+
+ // Add upstream database
+ if (upstream?.database) {
+ map.set(
+ nodeKey(
+ 'database',
+ upstream.database.id,
+ upstream.database.database_name,
+ ),
+ {
+ name: upstream.database.database_name,
+ type: 'database',
+ id: upstream.database.id,
+ },
+ );
+ }
+
+ // Add downstream dashboards
+ if (downstream?.dashboards?.result) {
+ downstream.dashboards.result.forEach((dashboard: DashboardEntity) => {
+ map.set(nodeKey('dashboard', dashboard.id, dashboard.title), {
+ name: dashboard.title,
+ type: 'dashboard',
+ id: dashboard.id,
+ additionalInfo: {
+ slug: dashboard.slug,
+ },
+ });
+ });
+ }
+ } else if (entityType === 'dashboard' && 'dashboard' in data) {
+ const { dashboard, upstream } = data as DashboardLineage;
+
+ // Add current dashboard
+ map.set(nodeKey('dashboard', dashboard.id, dashboard.title), {
+ name: dashboard.title,
+ type: 'dashboard',
+ id: dashboard.id,
+ additionalInfo: {
+ slug: dashboard.slug,
+ },
+ });
+
+ // Add upstream charts
+ if (upstream?.charts?.result) {
+ upstream.charts.result.forEach((chart: ChartEntity) => {
+ map.set(nodeKey('chart', chart.id, chart.slice_name), {
+ name: chart.slice_name,
+ type: 'chart',
+ id: chart.id,
+ additionalInfo: {
+ viz_type: chart.viz_type,
+ },
+ });
+ });
+ }
+
+ // Add upstream datasets
+ if (upstream?.datasets?.result) {
+ upstream.datasets.result.forEach((dataset: DatasetEntity) => {
+ map.set(nodeKey('dataset', dataset.id, dataset.name), {
+ name: dataset.name,
+ type: 'dataset',
+ id: dataset.id,
+ additionalInfo: {
+ schema: dataset.schema,
+ table_name: dataset.table_name,
+ },
+ });
+ });
+ }
+
+ // Add upstream databases
+ if (upstream?.databases?.result) {
+ upstream.databases.result.forEach((database: DatabaseEntity) => {
+ map.set(nodeKey('database', database.id, database.database_name), {
+ name: database.database_name,
+ type: 'database',
+ id: database.id,
+ });
+ });
+ }
+ }
+
+ return map;
+ }, [lineageResource, entityType]);
+
+ // Handle node click
+ const handleNodeClick = useCallback(
+ (params: any) => {
+ if (params.dataType === 'node') {
+ const nodeName = params.name;
+ const nodeDetails = nodeDetailsMap.get(nodeName);
+ if (nodeDetails) {
+ setSelectedNode(nodeDetails);
+ }
+ }
+ // Always stop event propagation to prevent tooltip issues
+ if (params.event) {
+ params.event.stop();
+ }
+ },
+ [nodeDetailsMap],
+ );
+
+ const echartOptions: EChartsCoreOption | null = useMemo(() => {
+ if (
+ lineageResource.status !== ResourceStatus.Complete ||
+ !lineageResource.result
+ ) {
+ return null;
+ }
+
+ const data = lineageResource.result;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing tests for new component</b></div>
<div id="fix">
New component has no unit tests. Adaptive rules 6262 and 11730 require
comprehensive tests covering success paths, error scenarios, and edge cases for
new tools/features.
</div>
</div>
<small><i>Code Review Run #9dcb5b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/src/features/lineage/LineageModal.tsx:
##########
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { FC, ReactNode } from 'react';
+import { t } from '@apache-superset/core/translation';
+import { ModalTrigger } from '@superset-ui/core/components';
+import {
+ useChartLineage,
+ useDashboardLineage,
+ useDatasetLineage,
+} from 'src/hooks/apiResources';
+import LineageView from './LineageView';
+
+export interface LineageModalProps {
+ entityType: 'dataset' | 'chart' | 'dashboard';
+ entityId: string | number;
+ triggerNode: ReactNode;
+}
+
+const LineageModal: FC<LineageModalProps> = ({
+ entityType,
+ entityId,
+ triggerNode,
+}) => {
+ const datasetLineage = useDatasetLineage(
+ entityType === 'dataset' ? entityId : '',
+ );
+ const chartLineage = useChartLineage(entityType === 'chart' ? entityId : '');
+ const dashboardLineage = useDashboardLineage(
+ entityType === 'dashboard' ? entityId : '',
+ );
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Unconditional hook calls waste resources</b></div>
<div id="fix">
Only invoke the lineage hook matching `entityType` to avoid empty-ID network
requests. For example, conditionally call `useChartLineage` only when
`entityType === 'chart'`, and similarly for dataset and dashboard, instead of
calling all three with empty fallbacks.
</div>
</div>
<small><i>Code Review Run #9dcb5b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/src/features/lineage/LineageView.tsx:
##########
@@ -0,0 +1,728 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { FC, useMemo, useState, useCallback } from 'react';
+import { t } from '@apache-superset/core/translation';
+import { styled, useTheme } from '@apache-superset/core/theme';
+import { Empty, Loading } from '@superset-ui/core/components';
+import { Button } from '@superset-ui/core/components';
+import { ResourceStatus } from 'src/hooks/apiResources/apiResources';
+import type { Resource } from 'src/hooks/apiResources/apiResources';
+import type {
+ DatasetLineage,
+ ChartLineage,
+ DashboardLineage,
+ ChartEntity,
+ DashboardEntity,
+ DatasetEntity,
+ DatabaseEntity,
+} from 'src/hooks/apiResources/lineage';
+import Echart from
'../../../plugins/plugin-chart-echarts/src/components/Echart';
+import type { EChartsCoreOption } from 'echarts/core';
+
+const LineageContainer = styled.div`
+ display: flex;
+ flex-direction: column;
+ width: 100%;
+ height: 100%;
+`;
+
+const Legend = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ justify-content: center;
+ align-items: center;
+ gap: ${theme.sizeUnit * 4}px;
+ padding: ${theme.sizeUnit * 3}px;
+ background-color: ${theme.colorBgLayout};
+ border-bottom: 1px solid ${theme.colorBorder};
+ `}
+`;
+
+const LegendItem = styled.div<{ color: string }>`
+ ${({ theme, color }) => `
+ display: flex;
+ align-items: center;
+ gap: ${theme.sizeUnit * 2}px;
+ font-size: ${theme.fontSizeSM}px;
+ color: ${theme.colorText};
+
+ &::before {
+ content: '';
+ width: 12px;
+ height: 12px;
+ border-radius: 2px;
+ background-color: ${color};
+ }
+ `}
+`;
+
+const DetailsPanel = styled.div`
+ ${({ theme }) => `
+ padding: ${theme.sizeUnit * 4}px;
+ background-color: ${theme.colorBgLayout};
+ border-top: 1px solid ${theme.colorBorder};
+ min-height: 120px;
+ `}
+`;
+
+const DetailsPanelHeader = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ justify-content: space-between;
+ align-items: center;
+ margin-bottom: ${theme.sizeUnit * 3}px;
+ `}
+`;
+
+const DetailsPanelActions = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ gap: ${theme.sizeUnit * 2}px;
+ `}
+`;
+
+const DetailsPanelTitle = styled.h4`
+ ${({ theme }) => `
+ margin: 0;
+ font-size: ${theme.fontSizeLG}px;
+ font-weight: ${theme.fontWeightStrong};
+ color: ${theme.colorText};
+ `}
+`;
+
+const DetailsPanelContent = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ flex-direction: column;
+ gap: ${theme.sizeUnit * 2}px;
+ `}
+`;
+
+const DetailRow = styled.div`
+ ${({ theme }) => `
+ display: flex;
+ gap: ${theme.sizeUnit * 2}px;
+ font-size: ${theme.fontSizeSM}px;
+ color: ${theme.colorText};
+ `}
+`;
+
+const DetailLabel = styled.span`
+ ${({ theme }) => `
+ font-weight: ${theme.fontWeightStrong};
+ min-width: 100px;
+ `}
+`;
+
+const DetailValue = styled.span`
+ ${({ theme }) => `
+ color: ${theme.colorTextSecondary};
+ `}
+`;
+
+type NodeType = 'database' | 'dataset' | 'chart' | 'dashboard';
+
+type NodeDetails = {
+ name: string;
+ type: NodeType;
+ id?: number;
+ additionalInfo?: Record<string, any>;
+};
+
+// Build a stable, unique graph identity for a node so that entities sharing
the
+// same display name (e.g. two charts with identical titles) never collapse
into
+// a single Sankey node. The human-readable name is kept separately as the
label.
+const nodeKey = (type: NodeType, id?: number, name?: string): string =>
+ id != null ? `${type}:${id}` : `${type}:${name ?? ''}`;
+
+type LineageViewProps = {
+ lineageResource:
+ | Resource<DatasetLineage>
+ | Resource<ChartLineage>
+ | Resource<DashboardLineage>;
+ entityType: 'dataset' | 'chart' | 'dashboard';
+};
+
+const LineageView: FC<LineageViewProps> = ({ lineageResource, entityType }) =>
{
+ const theme = useTheme();
+ const [selectedNode, setSelectedNode] = useState<NodeDetails | null>(null);
+
+ // Create a mapping of node names to their details
+ const nodeDetailsMap = useMemo(() => {
+ if (
+ lineageResource.status !== ResourceStatus.Complete ||
+ !lineageResource.result
+ ) {
+ return new Map<string, NodeDetails>();
+ }
+
+ const data = lineageResource.result;
+ const map = new Map<string, NodeDetails>();
+
+ if (entityType === 'dataset' && 'dataset' in data) {
+ const { dataset, upstream, downstream } = data as DatasetLineage;
+
+ // Add current dataset
+ map.set(nodeKey('dataset', dataset.id, dataset.name), {
+ name: dataset.name,
+ type: 'dataset',
+ id: dataset.id,
+ additionalInfo: {
+ schema: dataset.schema,
+ table_name: dataset.table_name,
+ database_name: dataset.database_name,
+ },
+ });
+
+ // Add upstream database
+ if (upstream?.database) {
+ map.set(
+ nodeKey(
+ 'database',
+ upstream.database.id,
+ upstream.database.database_name,
+ ),
+ {
+ name: upstream.database.database_name,
+ type: 'database',
+ id: upstream.database.id,
+ },
+ );
+ }
+
+ // Add downstream charts
+ if (downstream?.charts?.result) {
+ downstream.charts.result.forEach((chart: ChartEntity) => {
+ map.set(nodeKey('chart', chart.id, chart.slice_name), {
+ name: chart.slice_name,
+ type: 'chart',
+ id: chart.id,
+ additionalInfo: {
+ viz_type: chart.viz_type,
+ },
+ });
+ });
+ }
+
+ // Add downstream dashboards
+ if (downstream?.dashboards?.result) {
+ downstream.dashboards.result.forEach((dashboard: DashboardEntity) => {
+ map.set(nodeKey('dashboard', dashboard.id, dashboard.title), {
+ name: dashboard.title,
+ type: 'dashboard',
+ id: dashboard.id,
+ additionalInfo: {
+ slug: dashboard.slug,
+ },
+ });
+ });
+ }
+ } else if (entityType === 'chart' && 'chart' in data) {
+ const { chart, upstream, downstream } = data as ChartLineage;
+
+ // Add current chart
+ map.set(nodeKey('chart', chart.id, chart.slice_name), {
+ name: chart.slice_name,
+ type: 'chart',
+ id: chart.id,
+ additionalInfo: {
+ viz_type: chart.viz_type,
+ },
+ });
+
+ // Add upstream dataset
+ if (upstream?.dataset) {
+ map.set(
+ nodeKey('dataset', upstream.dataset.id, upstream.dataset.name),
+ {
+ name: upstream.dataset.name,
+ type: 'dataset',
+ id: upstream.dataset.id,
+ additionalInfo: {
+ schema: upstream.dataset.schema,
+ table_name: upstream.dataset.table_name,
+ },
+ },
+ );
+ }
+
+ // Add upstream database
+ if (upstream?.database) {
+ map.set(
+ nodeKey(
+ 'database',
+ upstream.database.id,
+ upstream.database.database_name,
+ ),
+ {
+ name: upstream.database.database_name,
+ type: 'database',
+ id: upstream.database.id,
+ },
+ );
+ }
+
+ // Add downstream dashboards
+ if (downstream?.dashboards?.result) {
+ downstream.dashboards.result.forEach((dashboard: DashboardEntity) => {
+ map.set(nodeKey('dashboard', dashboard.id, dashboard.title), {
+ name: dashboard.title,
+ type: 'dashboard',
+ id: dashboard.id,
+ additionalInfo: {
+ slug: dashboard.slug,
+ },
+ });
+ });
+ }
+ } else if (entityType === 'dashboard' && 'dashboard' in data) {
+ const { dashboard, upstream } = data as DashboardLineage;
+
+ // Add current dashboard
+ map.set(nodeKey('dashboard', dashboard.id, dashboard.title), {
+ name: dashboard.title,
+ type: 'dashboard',
+ id: dashboard.id,
+ additionalInfo: {
+ slug: dashboard.slug,
+ },
+ });
+
+ // Add upstream charts
+ if (upstream?.charts?.result) {
+ upstream.charts.result.forEach((chart: ChartEntity) => {
+ map.set(nodeKey('chart', chart.id, chart.slice_name), {
+ name: chart.slice_name,
+ type: 'chart',
+ id: chart.id,
+ additionalInfo: {
+ viz_type: chart.viz_type,
+ },
+ });
+ });
+ }
+
+ // Add upstream datasets
+ if (upstream?.datasets?.result) {
+ upstream.datasets.result.forEach((dataset: DatasetEntity) => {
+ map.set(nodeKey('dataset', dataset.id, dataset.name), {
+ name: dataset.name,
+ type: 'dataset',
+ id: dataset.id,
+ additionalInfo: {
+ schema: dataset.schema,
+ table_name: dataset.table_name,
+ },
+ });
+ });
+ }
+
+ // Add upstream databases
+ if (upstream?.databases?.result) {
+ upstream.databases.result.forEach((database: DatabaseEntity) => {
+ map.set(nodeKey('database', database.id, database.database_name), {
+ name: database.database_name,
+ type: 'database',
+ id: database.id,
+ });
+ });
+ }
+ }
+
+ return map;
+ }, [lineageResource, entityType]);
+
+ // Handle node click
+ const handleNodeClick = useCallback(
+ (params: any) => {
+ if (params.dataType === 'node') {
+ const nodeName = params.name;
+ const nodeDetails = nodeDetailsMap.get(nodeName);
+ if (nodeDetails) {
+ setSelectedNode(nodeDetails);
+ }
+ }
+ // Always stop event propagation to prevent tooltip issues
+ if (params.event) {
+ params.event.stop();
+ }
+ },
+ [nodeDetailsMap],
+ );
+
+ const echartOptions: EChartsCoreOption | null = useMemo(() => {
+ if (
+ lineageResource.status !== ResourceStatus.Complete ||
+ !lineageResource.result
+ ) {
+ return null;
+ }
+
+ const data = lineageResource.result;
+ const nodes: {
+ name: string;
+ label?: { position?: string; formatter?: string };
+ itemStyle?: { color: string };
+ }[] = [];
+ const links: { source: string; target: string; value: number }[] = [];
+ const nodeSet = new Set<string>();
+
+ // Helper to add a node. `key` is the stable unique identity used for graph
+ // links and detail lookups; `label` is the human-readable text shown.
+ const addNode = (
+ key: string,
+ label: string,
+ color: string,
+ labelPosition: 'left' | 'right' | 'inside',
+ ) => {
+ if (!nodeSet.has(key)) {
+ nodeSet.add(key);
+ nodes.push({
+ name: key,
+ itemStyle: { color },
+ label: {
+ position: labelPosition,
+ formatter: label,
+ },
+ });
+ }
+ };
+
+ // Helper to add a link between two node keys
+ const addLink = (source: string, target: string) => {
+ links.push({ source, target, value: 1 });
+ };
+
+ // Build nodes and links based on entity type
+ if (entityType === 'dataset' && 'dataset' in data) {
+ const { dataset, upstream, downstream } = data as DatasetLineage;
+
+ const datasetKey = nodeKey('dataset', dataset.id, dataset.name);
+ // Add current dataset node (center) - label inside
+ addNode(datasetKey, dataset.name, theme.colorPrimary, 'inside');
+
+ // Add upstream database - label on left
+ if (upstream?.database) {
+ const dbKey = nodeKey(
+ 'database',
+ upstream.database.id,
+ upstream.database.database_name,
+ );
+ addNode(
+ dbKey,
+ upstream.database.database_name,
+ theme.colorInfo,
+ 'left',
+ );
+ addLink(dbKey, datasetKey);
+ }
+
+ // Add downstream charts - label on right
+ const chartKeys = new Map<number, string>();
+ if (downstream?.charts?.result) {
+ downstream.charts.result.forEach((chart: ChartEntity) => {
+ const chartKey = nodeKey('chart', chart.id, chart.slice_name);
+ chartKeys.set(chart.id, chartKey);
+ addNode(chartKey, chart.slice_name, theme.colorSuccess, 'right');
+ addLink(datasetKey, chartKey);
+ });
+ }
+
+ // Add downstream dashboards - label on right
+ if (downstream?.dashboards?.result) {
+ downstream.dashboards.result.forEach((dashboard: DashboardEntity) => {
+ const dashKey = nodeKey('dashboard', dashboard.id, dashboard.title);
+ addNode(dashKey, dashboard.title, theme.colorWarning, 'right');
+
+ // Link from charts to dashboards using chart_ids
+ if (dashboard.chart_ids && dashboard.chart_ids.length > 0) {
+ dashboard.chart_ids.forEach(chartId => {
+ const chartKey = chartKeys.get(chartId);
+ if (chartKey) {
+ addLink(chartKey, dashKey);
+ }
+ });
+ }
+ });
+ }
+ } else if (entityType === 'chart' && 'chart' in data) {
+ const { chart, upstream, downstream } = data as ChartLineage;
+
+ const chartKey = nodeKey('chart', chart.id, chart.slice_name);
+ // Add current chart node (center) - label inside
+ addNode(chartKey, chart.slice_name, theme.colorPrimary, 'inside');
+
+ // Add upstream dataset - label on left
+ if (upstream?.dataset) {
+ const datasetKey = nodeKey(
+ 'dataset',
+ upstream.dataset.id,
+ upstream.dataset.name,
+ );
+ addNode(datasetKey, upstream.dataset.name, theme.colorInfo, 'left');
+ addLink(datasetKey, chartKey);
+
+ // Add upstream database - label on left
+ if (upstream.database) {
+ const dbKey = nodeKey(
+ 'database',
+ upstream.database.id,
+ upstream.database.database_name,
+ );
+ addNode(
+ dbKey,
+ upstream.database.database_name,
+ theme.colorWarning,
+ 'left',
+ );
+ addLink(dbKey, datasetKey);
+ }
+ }
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>CWE-561: Remove any type</b></div>
<div id="fix">
Uses `any` type for `datasetMap` which bypasses TypeScript type safety.
Import `DatasetEntity` from lineage.ts and use `Map<number, DatasetEntity>`
instead. (See also: [CWE-561](https://cwe.mitre.org/data/definitions/561.html))
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/superset-frontend/src/features/lineage/LineageView.tsx
+++ b/superset-frontend/src/features/lineage/LineageView.tsx
@@ -493,7 +493,7 @@ const LineageView: FC<LineageViewProps> = ({
lineageResource, entityType }) => {
}
// Create a map of dataset id to dataset for easy lookup
- const datasetMap = new Map<number, any>();
+ const datasetMap = new Map<number, DatasetEntity>();
if (upstream?.datasets?.result) {
upstream.datasets.result.forEach(dataset => {
datasetMap.set(dataset.id, dataset);
```
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/23123ce/.cursor/rules/dev-standard.mdc#L17";>dev-standard.mdc:17</a>
</li>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/23123ce/AGENTS.md#L115";>AGENTS.md:115</a>
</li>
</ul>
</details>
<small><i>Code Review Run #9dcb5b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
