bito-code-review[bot] commented on code in PR #40912:
URL: https://github.com/apache/superset/pull/40912#discussion_r3384057806
##########
superset-frontend/src/hooks/apiResources/apiResources.ts:
##########
@@ -86,6 +86,7 @@ const initialState: LoadingState = {
*/
export function useApiResourceFullBody<RESULT>(
endpoint: string,
+ skip = false,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing unit tests for skip parameter</b></div>
<div id="fix">
The new `skip` parameter lacks test coverage. Tests should verify
`skip=true` skips the fetch and returns Loading state, and that toggling `skip`
correctly re-enables/disabled API calls.
</div>
</div>
<small><i>Code Review Run #e7785a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
