bito-code-review[bot] commented on code in PR #40912:
URL: https://github.com/apache/superset/pull/40912#discussion_r3384767103
##########
superset-frontend/src/hooks/apiResources/apiResources.ts:
##########
@@ -86,6 +86,7 @@ const initialState: LoadingState = {
*/
export function useApiResourceFullBody<RESULT>(
endpoint: string,
+ skip = false,
Review Comment:
<!-- Bito Reply -->
The addition of unit tests for the `skip` parameter in
`apiResources.test.ts` effectively addresses the reviewer's concern regarding
test coverage. Verifying both the short-circuit behavior and the re-enabling of
the request ensures the parameter functions as intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
