bito-code-review[bot] commented on code in PR #40640: URL: https://github.com/apache/superset/pull/40640#discussion_r3383424556
########## superset/translations/ru/LC_MESSAGES/messages.po: ########## @@ -16988,6 +16988,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "Свойство `operation` не определено в объекте постобработки" +#, python-format +msgid "`periods` must be between 1 and %(max)s" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Russian translation</b></div> <div id="fix"> The `msgstr` is empty but the entry has `#, python-format` flag. Russian users will see the untranslated English error message "`periods` must be between 1 and %(max)s" when Prophet validation fails. Provide a Russian translation that preserves the %(max)s placeholder for runtime substitution. </div> </div> <small><i>Code Review Run #a0dd3d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -17943,6 +17943,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "La propriété « operation » de l'objet de post-traitement est indéfinie" +#, python-format +msgid "`periods` must be between 1 and %(max)s" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing French translation</b></div> <div id="fix"> The `msgstr` is empty while the `python-format` flag is present. French users will see the English message "`periods` must be between 1 and %(max)s" instead of a localized French translation when this validation error triggers. Please add the appropriate French translation. </div> </div> <small><i>Code Review Run #a0dd3d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -15964,6 +15964,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "後処理オブジェクトの `operation` プロパティが未定義です" +#, python-format +msgid "`periods` must be between 1 and %(max)s" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incomplete Japanese translation</b></div> <div id="fix"> The new translation entry for "`periods` must be between 1 and %(max)s" has an empty `msgstr`. Japanese users will see the English error message instead of a localized one. This message is used in `validate_prophet_periods()` in `superset/charts/schemas.py` for Prophet chart validation. </div> </div> <small><i>Code Review Run #a0dd3d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -18131,6 +18131,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "Propiedad «operation» del objeto de posprocesamiento no definida" +#, python-format +msgid "`periods` must be between 1 and %(max)s" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Spanish translation</b></div> <div id="fix"> The newly added msgid has an empty `msgstr`. Spanish-speaking users will see the raw English message instead of a translated one. Add the translation following the established pattern from line 18119 (`«confidence_interval» debe estar entre 0 y 1`). </div> </div> <small><i>Code Review Run #a0dd3d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/mi/LC_MESSAGES/messages.po: ########## @@ -17341,6 +17341,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "Kāore i tautuhia te āhuatanga `operation` o te ahanoa tukatuka-iho" +#, python-format +msgid "`periods` must be between 1 and %(max)s" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Māori translation for error message</b></div> <div id="fix"> The `msgstr` field is empty, so Māori-speaking users will see the untranslated English message when this validation error triggers in the Prophet chart configuration. Compare with line 3766 which has a proper Māori translation for a similar range-validation message. </div> </div> <small><i>Code Review Run #a0dd3d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
