bito-code-review[bot] commented on code in PR #40640: URL: https://github.com/apache/superset/pull/40640#discussion_r3383873695
########## superset/translations/ru/LC_MESSAGES/messages.po: ########## @@ -16988,6 +16988,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "Свойство `operation` не определено в объекте постобработки" +#, python-format +msgid "`periods` must be between 1 and %(max)s" +msgstr "" Review Comment: <!-- Bito Reply --> The decision to resolve this comment is appropriate. As noted, the empty `msgstr` is standard for new strings in this project, and the translation workflow relies on community contributions via Crowdin rather than manual updates in the source PR. ########## superset/translations/es/LC_MESSAGES/messages.po: ########## @@ -18131,6 +18131,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "Propiedad «operation» del objeto de posprocesamiento no definida" +#, python-format +msgid "`periods` must be between 1 and %(max)s" +msgstr "" Review Comment: <!-- Bito Reply --> The reviewer's suggestion to add a Spanish translation for the new `periods` message is noted. As you indicated, keeping the `msgstr` empty for new strings is standard practice in this project to allow for community-driven translation via the Crowdin workflow. No further action is required for this thread. ########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -15964,6 +15964,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "後処理オブジェクトの `operation` プロパティが未定義です" +#, python-format +msgid "`periods` must be between 1 and %(max)s" +msgstr "" Review Comment: <!-- Bito Reply --> The user's decision to resolve the thread is appropriate. As noted, the empty `msgstr` is standard practice for new translatable strings in this project, as the community-driven Crowdin workflow handles the actual translation updates independently of the source code PR. ########## superset/translations/fr/LC_MESSAGES/messages.po: ########## @@ -17943,6 +17943,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "La propriété « operation » de l'objet de post-traitement est indéfinie" +#, python-format +msgid "`periods` must be between 1 and %(max)s" Review Comment: <!-- Bito Reply --> The reviewer's suggestion to add a French translation for the new validation error is noted. As you correctly identified, empty `msgstr` entries for new strings are standard practice in this project to allow for community-driven translation via Crowdin, and the babel tooling is configured to handle these placeholders. No further action is required for this thread. ########## superset/translations/mi/LC_MESSAGES/messages.po: ########## @@ -17341,6 +17341,10 @@ msgstr "" msgid "`operation` property of post processing object undefined" msgstr "Kāore i tautuhia te āhuatanga `operation` o te ahanoa tukatuka-iho" +#, python-format +msgid "`periods` must be between 1 and %(max)s" +msgstr "" Review Comment: <!-- Bito Reply --> The reviewer's suggestion to add a Māori translation for the error message is noted. As you have clarified, the empty `msgstr` is intentional for new strings, and translations are managed through the community workflow. No action is required on this thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
