mikebridge commented on PR #40129: URL: https://github.com/apache/superset/pull/40129#issuecomment-4664677630
@richardfogaca — heads-up that this has changed since your approval, so it'll need another look. Rebased onto current master; the changes since: - **Deleted-state listing audience** — scoped `ChartDeletedStateFilter` to the restore audience (owners/admins), matching the decision on the dashboards PR (#40128) and `RestoreChartCommand`'s `raise_for_ownership`. A read-access non-owner can no longer enumerate soft-deleted charts they can't restore; live rows keep normal `ChartFilter` visibility. Added integration coverage (owner sees own deleted; gamma with datasource access does not). - **Migration head** — re-pointed `add_deleted_at_to_slices` `down_revision` from `33d7e0e21daa` to `31dae2559c05` (master's current head) to avoid an alembic multi-head against current master. (Will be re-pointed onto the dashboards migration during the charts→dashboards→datasets merge sequence.) - **Importer Case B** — keyed on `is_soft_deleted` rather than the fused `needs_mutation`, so an active chart re-imported with `overwrite=True` but no `can_write` returns the existing row instead of raising the restore error. Added a regression test. CI is green on HEAD `b9032c54`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
