aminghadersohi commented on code in PR #40634:
URL: https://github.com/apache/superset/pull/40634#discussion_r3385778027
##########
superset/charts/schemas.py:
##########
@@ -695,6 +709,7 @@ class
ChartDataProphetOptionsSchema(ChartDataPostProcessingOperationOptionsSchem
"the future",
"example": 7,
"min": 1,
+ "max": 10000,
Review Comment:
**[NIT]** `"max": 10000` is a magic number here. Prefer
`DEFAULT_MAX_PROPHET_PERIODS` so the metadata is visibly tied to the constant
that governs the default bound — and note that this static value won't reflect
a custom `MAX_PROPHET_PERIODS` in the generated OpenAPI spec.
```suggestion
"max": DEFAULT_MAX_PROPHET_PERIODS,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
