rusackas commented on code in PR #40634:
URL: https://github.com/apache/superset/pull/40634#discussion_r3385858934
##########
superset/charts/schemas.py:
##########
@@ -695,6 +709,7 @@ class
ChartDataProphetOptionsSchema(ChartDataPostProcessingOperationOptionsSchem
"the future",
"example": 7,
"min": 1,
+ "max": 10000,
Review Comment:
Good call — replaced the magic `10000` with `DEFAULT_MAX_PROPHET_PERIODS` so
the metadata is tied to the governing constant. Noted that the static value
won't reflect a runtime-custom `MAX_PROPHET_PERIODS` override in the generated
OpenAPI spec, but the metadata now points at the same default the validator
falls back to. Pushed in 51d801d0e9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
