codeant-ai-for-open-source[bot] commented on code in PR #40130:
URL: https://github.com/apache/superset/pull/40130#discussion_r3397307201
##########
tests/integration_tests/security_tests.py:
##########
@@ -560,6 +560,72 @@ def
test_after_update_database__perm_datasource_access(self):
db.session.delete(tmp_db1)
db.session.commit()
+ def test_after_update_database__perm_datasource_access_soft_deleted(self):
Review Comment:
**Suggestion:** Add explicit type hints to this newly added test method,
including a return annotation (`-> None`), to meet the requirement that new
Python code be fully typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test method, and it has no return type
annotation.
Under the stated rule, new Python code should be fully typed, so omitting
`-> None`
is a real violation.
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=900b697e97844ab1afc8573ddf50cca6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=900b697e97844ab1afc8573ddf50cca6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/security_tests.py
**Line:** 563:563
**Comment:**
*Custom Rule: Add explicit type hints to this newly added test method,
including a return annotation (`-> None`), to meet the requirement that new
Python code be fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40130&comment_hash=c789363f4c171ec882784943e842a1e4b7575af5a97046b5911e82485421b25c&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40130&comment_hash=c789363f4c171ec882784943e842a1e4b7575af5a97046b5911e82485421b25c&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
