mikebridge commented on PR #40130: URL: https://github.com/apache/superset/pull/40130#issuecomment-4685709227
Final triage sweep of the open bot threads (codeant + bito), regenerated by the recent pushes — resolving as not actionable: - **Docstring suggestions** (migration upgrade/downgrade fns, exception classes, test helpers): not this repo's convention — migration functions and test helpers are consistently undocstringed across the codebase; the substantive helpers added by this PR carry docstrings where they earn them. - **Empty `msgstr` entries**: by design — new source strings ship with empty `msgstr` (gettext falls back to the English msgid); translations land via the project translation workflow. Documented in earlier triage comments on this PR. - **Migration filename hyphens**: the `YYYY-MM-DD_HH-MM_hash_description.py` pattern is Superset's documented migration naming convention (CLAUDE.md); alembic loads migrations by path, not import. The file compiles and CI is green. - **Test-hygiene nits** (try/finally placement, mock verification): cosmetic; suites are green and the integration DB is rebuilt per branch. - **"Missing integration test" for the restore-failure 422 handler**: it exists — `tests/integration_tests/datasets/soft_delete_tests.py::TestDatasetRestore::test_restore_failure_returns_422` patches the command to raise and asserts the 422 mapping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
