bito-code-review[bot] commented on code in PR #40128:
URL: https://github.com/apache/superset/pull/40128#discussion_r3399304108


##########
superset/translations/ko/LC_MESSAGES/messages.po:
##########
@@ -4322,6 +4322,9 @@ msgstr "대시보드를 업데이트할 수 없습니다."
 msgid "Dashboard could not be deleted."
 msgstr "대시보드를 삭제할 수 없습니다."
 
+msgid "Dashboard could not be restored."
+msgstr ""

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Missing Korean Translation</b></div>
   <div id="fix">
   
   The `msgstr` at line 4326 is empty, so Korean locale users will see 
untranslated English text when `DashboardRestoreFailedError` is raised. Add 
`msgstr "대시보드를 복원할 수 없습니다."` to match the translation pattern used for similar 
messages in this file.
   </div>
   
   
   <details>
   <summary>
   <b>Code suggestion</b>
   </summary>
   <blockquote>Check the AI-generated fix before applying</blockquote>
   <div id="code">
   
   
   ```
    --- superset/translations/ko/LC_MESSAGES/messages.po (lines 4325-4326)
    4325: msgid "Dashboard could not be restored."
    4326:-msgstr ""
    4326:+msgstr "대시보드를 복원할 수 없습니다."
   ```
   
   </div>
   </details>
   
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #ccf830</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a 
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
superset/migrations/versions/2026-05-08_12-05_9e1f3b8c4d2a_add_deleted_at_to_dashboards.py:
##########
@@ -0,0 +1,184 @@
+# Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Invalid Python module name with hyphens</b></div>
   <div id="fix">
   
   The filename contains hyphens which are invalid in Python module names. 
Rename the file to use underscores instead (e.g., 
`2026_05_08_12_05_9e1f3b8c4d2a_add_deleted_at_to_dashboards.py`).
   </div>
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #ccf830</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a 
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to