bito-code-review[bot] commented on code in PR #40128:
URL: https://github.com/apache/superset/pull/40128#discussion_r3389955033
##########
superset/dashboards/api.py:
##########
@@ -1213,6 +1235,64 @@ def bulk_delete(self, **kwargs: Any) -> Response:
except DashboardDeleteFailedError as ex:
return self.response_422(message=str(ex))
+ @expose("/<uuid>/restore", methods=("POST",))
+ @protect()
+ @safe
+ @statsd_metrics
+ @event_logger.log_this_with_context(
+ action=lambda self, *args, **kwargs:
f"{self.__class__.__name__}.restore",
+ log_to_statsd=False,
+ )
+ def restore(self, uuid: str) -> Response:
+ """Restore a soft-deleted dashboard.
+ ---
+ post:
+ summary: Restore a soft-deleted dashboard
+ parameters:
+ - in: path
+ schema:
+ type: string
+ format: uuid
+ name: uuid
+ responses:
+ 200:
+ description: Dashboard restored
+ content:
+ application/json:
+ schema:
+ type: object
+ properties:
+ message:
+ type: string
+ 401:
+ $ref: '#/components/responses/401'
+ 403:
+ $ref: '#/components/responses/403'
+ 404:
+ $ref: '#/components/responses/404'
+ 422:
+ $ref: '#/components/responses/422'
+ 500:
+ $ref: '#/components/responses/500'
+ """
+ try:
+ RestoreDashboardCommand(uuid).run()
+ return self.response(200, message="OK")
+ except DashboardNotFoundError:
+ return self.response_404()
+ except DashboardForbiddenError:
+ return self.response_403()
+ except DashboardSlugConflictError as ex:
+ return self.response_422(message=str(ex))
+ except DashboardRestoreFailedError as ex:
+ logger.error(
+ "Error restoring model %s: %s",
+ self.__class__.__name__,
+ str(ex),
+ exc_info=True,
+ )
+ return self.response_422(message=str(ex))
Review Comment:
<!-- Bito Reply -->
The suggestion to add test coverage for the `DashboardRestoreFailedError`
exception handler is valid and appropriate. The user has correctly identified
that the error path is now covered by the integration test
`tests/integration_tests/dashboards/soft_delete_tests.py::TestDashboardRestore::test_restore_failure_returns_422`,
which patches `RestoreDashboardCommand.run` to raise the expected error and
verifies the 422 response. No further action is required for this suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
