bito-code-review[bot] commented on code in PR #40128:
URL: https://github.com/apache/superset/pull/40128#discussion_r3391132886
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -4434,6 +4434,9 @@ msgstr "Le tableau de bord n'a pas pu être mis à jour."
msgid "Dashboard could not be deleted."
msgstr "Le tableau de bord n'a pas pu être supprimé."
+msgid "Dashboard could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing French translation</b></div>
<div id="fix">
The new `msgid "Dashboard could not be restored."` has an empty `msgstr`.
French users will see untranslated English text when this error occurs. Use the
same pattern as adjacent translations: "Le tableau de bord n'a pas pu être
restauré.".
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset/translations/fr/LC_MESSAGES/messages.po
+++ superset/translations/fr/LC_MESSAGES/messages.po
@@ -4435,7 +4435,7 @@ msgstr "Le tableau de bord n'a pas pu être supprimé."
msgid "Dashboard could not be restored."
-msgstr ""
+msgstr "Le tableau de bord n'a pas pu être restauré."
msgid "Dashboard could not be updated."
msgstr "Le tableau de bord n'a pas pu être mis à jour."
```
</div>
</details>
</div>
<small><i>Code Review Run #0eca9b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/th/LC_MESSAGES/messages.po:
##########
@@ -7613,6 +7613,9 @@ msgstr "ไม่สามารถลบแดชบอร์ดได้"
# de, es, fa, fr, it, ja, ko, lv, mi, nl, pl, pt, pt_BR, ru, sk, sl, tr, uk,
# zh, zh_TW]
#, fuzzy
+msgid "Dashboard could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Thai translation</b></div>
<div id="fix">
The new translation entry for 'Dashboard could not be restored.' has an
empty `msgstr ""` while similar entries like 'Dashboard could not be deleted.'
have proper Thai translations. Thai users will see untranslated English text.
Add the missing Thai translation.
</div>
</div>
<small><i>Code Review Run #0eca9b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/pl/LC_MESSAGES/messages.po:
##########
@@ -4565,6 +4565,9 @@ msgstr "Nie można zaktualizować pulpitu nawigacyjnego."
msgid "Dashboard could not be deleted."
msgstr "Nie można usunąć pulpitu nawigacyjnego."
+msgid "Dashboard could not be restored."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Polish translation for error</b></div>
<div id="fix">
The `msgstr` for "Dashboard could not be restored." is empty. Polish users
will see the untranslated English error message when a dashboard restore fails
via the `DashboardRestoreFailedError` exception (defined in
`superset/commands/dashboard/exceptions.py:81`). This degrades the user
experience for an error condition that users will encounter. Note: other
language files (de, fr, es, pt_BR, ja, zh) also have empty translations for
this string, suggesting a broader translation gap for this new feature.
</div>
</div>
<small><i>Code Review Run #0eca9b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
