rusackas commented on code in PR #40967:
URL: https://github.com/apache/superset/pull/40967#discussion_r3400936782
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -472,6 +560,24 @@ export default function transformProps(
}
}
+ let symbolSizeFn:
+ | ((value: (number | string | null)[]) => number)
+ | undefined;
+ if (sizeExtent) {
+ const extent = sizeExtent;
+ const sizeLookup = sizeLookups?.get(getSeriesDimsKey(entryName));
+ if (sizeIsValueMetric || sizeLookup) {
+ symbolSizeFn = value => {
+ const sizeValue = sizeIsValueMetric
+ ? value[isHorizontal ? 0 : 1]
+ : sizeLookup!.get(value[isHorizontal ? 1 : 0]);
+ return typeof sizeValue === 'number'
+ ? getAreaScaledSymbolSize(sizeValue, extent, markerSizeRange)
+ : markerSize;
Review Comment:
Yeah, that fallback was pointing at a hidden control. Missing size values
fall back to `minMarkerSize` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
