sha174n commented on PR #39301: URL: https://github.com/apache/superset/pull/39301#issuecomment-4694570564
@rusackas the databend spec was reverted to `is_hostname_valid` (so internal/RFC-1918 Databend hosts save and test fine); couchbase and databricks were reverted too. The host check now only applies to the outbound-fetch paths (dataset import, webhook), and impala's cancel_query gained an `IMPALA_CANCEL_QUERY_ALLOW_INTERNAL_HOSTS` opt-out. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
