sha174n commented on code in PR #39301:
URL: https://github.com/apache/superset/pull/39301#discussion_r3408313722
##########
superset/reports/notifications/webhook.py:
##########
@@ -93,6 +94,31 @@ def _get_files(self) -> list[tuple[str, tuple[str, bytes,
str]]]:
)
return files
+ def _validate_webhook_url(self, url: str) -> None:
Review Comment:
Added a docstring to `_validate_webhook_url` describing the checks it
performs and the `NotificationParamException` it raises in cfe88e7728.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
