sha174n commented on code in PR #39301:
URL: https://github.com/apache/superset/pull/39301#discussion_r3408384060
##########
superset/reports/notifications/webhook.py:
##########
@@ -121,9 +151,17 @@ def send(self) -> None:
else:
data[key] = value
- response = requests.post(wh_url, data=data, files=files,
timeout=60)
+ response = requests.post(
+ wh_url,
+ data=data,
+ files=files,
+ timeout=60,
+ allow_redirects=False,
+ )
Review Comment:
Fixed in 474294c: a 3xx is now treated as a failure. Since redirects are not
followed (allow_redirects=False), a 3xx means the request never reached the
final target, so it no longer reports success. Added a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
