rusackas commented on code in PR #33247:
URL: https://github.com/apache/superset/pull/33247#discussion_r3407806257
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/controlPanel.ts:
##########
@@ -352,15 +354,56 @@ const config: ControlPanelConfig = {
},
],
[
+ {
+ name: 'point_radius',
+ config: {
+ type: 'SelectControl',
+ freeForm: true,
+ label: t('Point Radius'),
+ description: t(
+ 'The radius of point features, in the units specified below. '
+
+ 'The final rendered size is this value multiplied by Point
Radius Scale.',
+ ),
+ validators: [validateInteger],
+ default: 10,
+ choices: formatSelectOptions([1, 5, 10, 20, 50, 100]),
+ renderTrigger: true,
+ },
+ },
{
name: 'point_radius_scale',
config: {
type: 'SelectControl',
freeForm: true,
label: t('Point Radius Scale'),
- validators: [legacyValidateInteger],
- default: null,
- choices: formatSelectOptions([0, 100, 200, 300, 500]),
+ description: t(
+ 'A multiplier applied to the point radius. ' +
+ 'Use this to uniformly scale all points.',
+ ),
+ validators: [validateNumber],
+ default: 1,
+ choices: formatSelectOptions([0.1, 0.5, 1, 2, 5, 10]),
+ renderTrigger: true,
+ },
+ },
+ ],
+ [
+ {
+ name: 'point_radius_units',
+ config: {
+ type: 'SelectControl',
+ label: t('Point Radius Units'),
+ description: t(
+ 'The unit for point radius. Use "pixels" for consistent ' +
+ 'screen-space sizing regardless of zoom level.',
+ ),
+ default: 'pixels',
Review Comment:
Good catch, and you're right that the runtime `?? 1` fallback in
`Geojson.tsx` never fires on the dashboard path because `applyDefaultFormData`
fills the control default first. The tradeoff is deliberate though: defaulting
new charts to pixels/10 was the whole point here, and there's no reliable
signal in `applyDefaultFormData` to tell a brand-new chart from a legacy one
missing the field. I'd rather take the slight visual shift on old GeoJSON
charts than ship undefined-by-default controls. Open to a migration if folks
feel strongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
