rusackas commented on code in PR #33247:
URL: https://github.com/apache/superset/pull/33247#discussion_r3416914292
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/Geojson.tsx:
##########
@@ -328,7 +335,11 @@ export const getLayer: GetLayerType<GeoJsonLayer> =
function ({
getFillColor(feature, filterState?.value),
getLineColor,
getLineWidth: fd.line_width || 1,
- pointRadiusScale: fd.point_radius_scale,
+ // Use deck.gl defaults as fallbacks for backward compatibility with
existing charts.
+ // New charts will get control panel defaults (point_radius=10,
units='pixels', scale=1).
+ getPointRadius: toNumber(fd.point_radius, 1),
+ pointRadiusUnits: fd.point_radius_units ?? 'meters',
Review Comment:
The `meters` fallback is deliberate, not a slip. Existing charts have no
`point_radius_units`, so this branch keeps them on deck.gl's old `meters`
behavior; new charts pick up `pixels` from the control panel default instead.
Flipping the fallback to `pixels` would silently resize every legacy GeoJSON
chart, which is exactly what we fixed earlier in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
