bito-code-review[bot] commented on code in PR #33247:
URL: https://github.com/apache/superset/pull/33247#discussion_r3416914923
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/Geojson.tsx:
##########
@@ -328,7 +335,11 @@ export const getLayer: GetLayerType<GeoJsonLayer> =
function ({
getFillColor(feature, filterState?.value),
getLineColor,
getLineWidth: fd.line_width || 1,
- pointRadiusScale: fd.point_radius_scale,
+ // Use deck.gl defaults as fallbacks for backward compatibility with
existing charts.
+ // New charts will get control panel defaults (point_radius=10,
units='pixels', scale=1).
+ getPointRadius: toNumber(fd.point_radius, 1),
+ pointRadiusUnits: fd.point_radius_units ?? 'meters',
Review Comment:
<!-- Bito Reply -->
The concern regarding backward compatibility is noted. Maintaining 'meters'
as the fallback for existing charts prevents unintended resizing, while the
change to 'pixels' correctly aligns new charts with the control panel default.
This approach balances legacy support with the intended behavior for new
configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
