aminghadersohi commented on PR #38567: URL: https://github.com/apache/superset/pull/38567#issuecomment-4713035764
Thanks @mistercrunch. All four items have been addressed: 1. **matrixify.test.ts reverted** — the unrelated changes are gone; file is back to master and no longer in the diff. 2. **PR checklist** — `[x] Removes existing feature or API` is now checked. 3. **UPDATING.md** — entry added under `## Next` documenting the removal of `thumbnail_url` from list responses and how to construct the URL client-side. 4. **`'default'` fallback removed** — `DashboardCard.tsx` now returns `''` (no thumbnail) when both `changed_on_utc` and `changed_on` are absent, rather than using `'default'` as a cache key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
