aminghadersohi commented on PR #38567: URL: https://github.com/apache/superset/pull/38567#issuecomment-4713036329
Thanks @kgabryje. Both nits addressed: - **`thumbnail_url` nullability** — changed to `thumbnail_url?: string | null` in `views/CRUD/types.ts` to match the detail endpoint schema (where it is `string | null`), while keeping it optional since list responses no longer include it. Also removed the now-stale `thumbnail_url: string` from the local `Dashboard` interface in `DashboardList/index.tsx`. - **UPDATING.md wording** — clarified that the redirect goes to the current digest URL (not directly to a cached image), and that the digest URL may return `202` and trigger async generation if the image is not yet cached. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
