aminghadersohi commented on code in PR #38567:
URL: https://github.com/apache/superset/pull/38567#discussion_r3416973371
##########
superset-frontend/packages/superset-ui-core/src/chart/types/matrixify.test.ts:
##########
@@ -40,10 +41,10 @@ test('isMatrixifyEnabled should return false when no
matrixify configuration exi
test('isMatrixifyEnabled should return false when layout controls are
disabled', () => {
const formData = {
viz_type: 'table',
- matrixify_mode_rows: 'disabled',
- matrixify_mode_columns: 'disabled',
+ matrixify_mode_rows: 'disabled' as const,
+ matrixify_mode_columns: 'disabled' as const,
matrixify_rows: [createMetric('Revenue')],
Review Comment:
The changes were an unrelated addition that didn't belong in this PR. They
have been reverted — the file is back to master and no longer appears in the
diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
