sadpandajoe opened a new pull request, #41128: URL: https://github.com/apache/superset/pull/41128
### SUMMARY The SQL Lab "Template parameters" popover was overflowing on typical laptop viewports because the embedded JSON editor was hardcoded to `height="800px"`. This PR shrinks it to `360px` and adds a visible outline around the editor so it reads as a clearly framed code block (consistent with the SQL block in Explore → View Query). It also removes a styled wrapper (`StyledEditorHost`) whose `&.ace_editor` selector never actually matched — the styled-component class was being applied to the EditorHost wrapper while the `.ace_editor` class lives on a deeper Ace DOM node — and replaces it with an `EditorOutline` div that applies the border directly. The new border uses `theme.colorBorder` and `theme.borderRadius` so it tracks both light and dark themes, matching the established idiom in `CssTemplateModal`, `KeyboardShortcutButton`, `ThemeModal`, and `AnnotationLayerModal`. A second commit (`chore(docker)`) turns on `ENABLE_TEMPLATE_PROCESSING` in `docker/pythonpath_dev/superset_config.py` so the "Parameters" menu item is reachable in the docker-compose-light dev image and Showtime preview environments — the popover is otherwise gated by that flag (`SqlEditor/index.tsx`). The production default in `superset/config.py` is unchanged (still `False`). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!-- Pending — will be added once Showtime is up. --> ### TESTING INSTRUCTIONS 1. Open SQL Lab. 2. Click the ⋯ (ellipsis) button above the SQL editor. 3. Select **Parameters**. 4. Verify the popover fits within the browser window on a 1280×800 viewport. 5. Verify the JSON editor has a clearly visible outline in both light and dark themes. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
