bito-code-review[bot] commented on PR #41128:
URL: https://github.com/apache/superset/pull/41128#issuecomment-4723641959
<!-- Bito Reply -->
The concern regarding `overflow: hidden` on the `EditorOutline` wrapper is
valid, as it can indeed clip Ace editor popovers or autocomplete menus that
extend beyond the container's bounds. To address this while maintaining the
desired border-radius, you can remove `overflow: hidden` from the wrapper and
instead apply the `border-radius` directly to the `EditorHost` component or its
internal `.ace_editor` class.
**superset-frontend/src/SqlLab/components/TemplateParamsEditor/index.tsx**
```
const EditorOutline = styled.div`
border: 1px solid ${({ theme }) => theme.colorBorder};
border-radius: ${({ theme }) => theme.borderRadius}px;
`;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
